From: Amar Lior <lior@cs.huji.ac.il>
To: linux-kernel@vger.kernel.org
Cc: Amar Lior <lior@cs.huji.ac.il>
Subject: PROBLEM
Date: Tue, 31 Dec 2002 18:18:01 +0200 (IST) [thread overview]
Message-ID: <Pine.LNX.4.20_heb2.08.0212311805480.29415-100000@mos214.cs.huji.ac.il> (raw)
Hi all,
I found a bug that cause the kernel to lockup.
The problem is in mm/shmem.c do_shmem_file_read() (the tmpfs)
at line 959 there is a call to file_read_actor(desc, page, offset, nr);
The problem is that inside the function file_read_actor() desc->error is
set to -EFAULT (this happens when the buffer supplied by the user for the
read is wrong)
but there is no check right after the return from file_read_actor() to
test this situation.
The result is that the desc->count field always stay the same and the
while loop in do_shmem_file_read never end and the kernel locksup.
The fix is very simple just add the following line after the call to
file_read_actor():
-------------------
if(desc->error)
break
-------------------
If you need any other info please mail me
Regards
--lior
________________________________________________________________
Lior Amar Distributed Computing Lab MOSIX
E-mail : lior@cs.huji.ac.il
________________________________________________________________
next reply other threads:[~2002-12-31 16:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-31 16:18 Amar Lior [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-04-27 1:35 PROBLEM Thomas Kayser
2006-02-03 12:02 PROBLEM Badri Pillai
2004-12-24 4:22 PROBLEM Scott Mollica
2004-12-27 3:28 ` PROBLEM Adrian Bunk
2003-12-19 18:10 PROBLEM Federico Freire
2003-12-19 18:25 ` PROBLEM Jean-Philippe Woot de Trixhe
2003-12-19 19:29 ` PROBLEM Jose Luis Domingo Lopez
2003-11-30 4:07 PROBLEM Mike Morrell
2003-11-30 6:05 ` PROBLEM Chris Ernst
2003-10-21 13:39 PROBLEM laurent.miaille
2003-03-13 21:40 Problem Smiler
2003-03-09 11:49 PROBLEM Kósa Ferenc
2003-03-09 12:55 ` PROBLEM John Bradford
2002-12-31 16:19 Problem Amar Lior
2002-12-31 17:38 ` Problem Hugh Dickins
2002-08-29 19:55 Problem Ryan White
2002-08-14 14:20 PROBLEM Bob Kruger
2001-09-11 23:16 Problem George Lloyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.20_heb2.08.0212311805480.29415-100000@mos214.cs.huji.ac.il \
--to=lior@cs.huji.ac.il \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).