From: Dan Aloni <karrde@callisto.yi.org>
To: Thiago Rondon <maluco@mileniumnet.com.br>
Cc: dahinds@users.sourceforge.net,
linux-kernel <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: ds patch
Date: Wed, 10 Jan 2001 23:30:17 +0200 (IST) [thread overview]
Message-ID: <Pine.LNX.4.21.0101102313310.27620-100000@callisto.yi.org> (raw)
In-Reply-To: <Pine.LNX.4.21.0101101623150.4170-100000@freak.mileniumnet.com.br>
On Wed, 10 Jan 2001, Thiago Rondon wrote:
> Check kmalloc().
In case where kmalloc() failed we shouldn't increase driver->use_count,
because we wouldn't be able to decrease it at unbind_request(), since we
got no matching socket_bind_t in the list.
Prehaps the increase of the use count should be moved after the
check. Like:
--- linux/drivers/pcmcia/ds.c Sat Sep 2 10:13:49 2000
+++ linux/drivers/pcmcia/ds.c Wed Jan 10 23:23:10 2001
@@ -412,8 +412,11 @@
}
/* Add binding to list for this socket */
- driver->use_count++;
b = kmalloc(sizeof(socket_bind_t), GFP_KERNEL);
+ if (!b)
+ return -ENOMEM;
+
+ driver->use_count++;
b->driver = driver;
b->function = bind_info->function;
b->instance = NULL;
> -Thiago Rondon
>
> --- linux-2.4.0-ac5/drivers/pcmcia/ds.c Sat Sep 2 04:13:49 2000
> +++ linux-2.4.0-ac5.maluco/drivers/pcmcia/ds.c Wed Jan 10 16:20:53 2001
> @@ -414,6 +414,8 @@
> /* Add binding to list for this socket */
> driver->use_count++;
> b = kmalloc(sizeof(socket_bind_t), GFP_KERNEL);
> + if (!b)
> + return -ENOMEM;
> b->driver = driver;
> b->function = bind_info->function;
> b->instance = NULL;
--
Dan Aloni
dax@karrde.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-01-10 21:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-01-10 18:24 Thiago Rondon
2001-01-10 21:30 ` Dan Aloni [this message]
2001-01-11 4:08 ` your mail David Hinds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.21.0101102313310.27620-100000@callisto.yi.org \
--to=karrde@callisto.yi.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dahinds@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maluco@mileniumnet.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).