linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo@conectiva.com.br>
To: Rik van Riel <riel@conectiva.com.br>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vmscan.c fixes
Date: Mon, 14 May 2001 19:25:32 -0300 (BRT)	[thread overview]
Message-ID: <Pine.LNX.4.21.0105141922490.32493-100000@freak.distro.conectiva> (raw)
In-Reply-To: <Pine.LNX.4.21.0105140335580.4671-100000@imladris.rielhome.conectiva>



On Mon, 14 May 2001, Rik van Riel wrote:

> Hi Linus,
> 
> the following patch does:


<snip>

>  	pg_data_t *pgdat = pgdat_list;
>  	int sum = 0;
>  	int freeable = nr_free_pages() + nr_inactive_clean_pages();
> +	/* XXX: dynamic free target is complicated and may be wrong... */
>  	int freetarget = freepages.high + inactive_target / 3;

I think its better if we just remove " + inactive_target / 3" here ---
callers already account for the inactive_target when trying to
calculate the free target anyway.

Example: 

static int refill_inactive(unsigned int gfp_mask, int user)
{
        int count, start_count, maxtry;

        count = inactive_shortage() + free_shortage();

...



  reply	other threads:[~2001-05-15  0:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-14  6:54 [PATCH] vmscan.c fixes Rik van Riel
2001-05-14 22:25 ` Marcelo Tosatti [this message]
2001-05-15  0:57   ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.21.0105141922490.32493-100000@freak.distro.conectiva \
    --to=marcelo@conectiva.com.br \
    --cc=linux-kernel@vger.kernel.org \
    --cc=riel@conectiva.com.br \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).