From: Matan Ziv-Av <matan@svgalib.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Russell King <rmk@arm.linux.org.uk>, mythos <papadako@csd.uoc.gr>,
linux-kernel@vger.kernel.org
Subject: Re: Can't compile 2.4.3 with agcc
Date: Tue, 24 Apr 2001 00:03:26 +0300 (IDT) [thread overview]
Message-ID: <Pine.LNX.4.21_heb2.09.0104232359390.2200-100000@matan.home> (raw)
In-Reply-To: <24644.988041173@redhat.com>
On Mon, 23 Apr 2001, David Woodhouse wrote:
> --- include/asm/bugs.h 2001/01/18 13:56:53 1.2.2.16
> +++ include/asm/bugs.h 2001/04/23 15:45:28
> @@ -80,8 +80,10 @@
> * Verify that the FXSAVE/FXRSTOR data will be 16-byte aligned.
> */
> if (offsetof(struct task_struct, thread.i387.fxsave) & 15) {
> - extern void __buggy_fxsr_alignment(void);
> - __buggy_fxsr_alignment();
> + printk(KERN_EMERG "ERROR: FXSAVE data are not 16-byte aligned in task_struct.\n");
> + printk(KERN_EMERG "This is usually caused by a buggy compiler (perhaps pgcc?)\n");
> + printk(KERN_EMERG "Cannot continue.\n");
> + for (;;) ;
This is known at compile time, right?
Would it not be better to replace the printk with #error ? Why do I need
to boot the bad kernel to find out that it does not work, when it is
known when compiling?
--
Matan Ziv-Av. matan@svgalib.org
next prev parent reply other threads:[~2001-04-23 21:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-23 13:13 Can't compile 2.4.3 with agcc mythos
2001-04-23 14:48 ` Russell King
2001-04-23 15:27 ` Alan Cox
2001-04-23 15:52 ` David Woodhouse
2001-04-23 17:57 ` Ingo Oeser
2001-04-23 19:43 ` Alan Cox
2001-04-23 20:46 ` David Woodhouse
2001-04-23 21:03 ` Matan Ziv-Av [this message]
2001-04-23 21:16 ` David Woodhouse
2001-04-23 22:32 ` Andrzej Krzysztofowicz
2001-04-23 22:54 ` David Woodhouse
2001-04-24 8:53 ` Russell King
2001-04-24 12:37 ` David Woodhouse
2001-04-23 22:25 ` Horst von Brand
2001-04-23 22:35 ` David Woodhouse
2001-04-24 13:28 ` Horst von Brand
2001-04-24 13:30 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.21_heb2.09.0104232359390.2200-100000@matan.home \
--to=matan@svgalib.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=papadako@csd.uoc.gr \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).