From: David Woodhouse <dwmw2@infradead.org>
To: Keith Owens <kaos@ocs.com.au>
Cc: Rasmus Andersen <rasmus@jaquet.dk>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] link time error in drivers/mtd (240t13p2)
Date: Sun, 17 Dec 2000 10:44:09 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.30.0012171039400.14423-100000@imladris.demon.co.uk> (raw)
In-Reply-To: <1875.977049144@ocs3.ocs-net>
On Sun, 17 Dec 2000, Keith Owens wrote:
> Messing about with conditional compilation because the link order is
> incorrect is the wrong fix. The mtd/Makefile must link the objects in
> the correct order.
The conditional compilation is far more obvious to people than subtle
issues with link order. So I prefer to avoid the latter at all costs.
I have to have some conditional compilation in my tree to allow it to
compile under 2.0 uClinux. Admittedly that doesn't have to get into 2.4,
but I obviously prefer the code in 2.4 to be as close to my working copy
as possible.
I'll poke at it and try to come up with a cleaner solution. It may be that
I can shift all the conditional stuff off into the compatmac.h and leave
the 'real' code path in a cleaner state than the current one.
> 2.4.0-test13-pre2 almost does that, the only obvious problem is that
> cfi_probe appears before cfi_cmdset. Move cfi_probe to link after
> cfi_cmdset, do you still get link order problems with the 2.4.0-test11
> version of include/linux/mtd.h?
I haven't had problems. But the possibility exists.
--
dwmw2
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-12-17 11:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-16 22:07 [PATCH] link time error in drivers/mtd (240t13p2) Rasmus Andersen
2000-12-16 23:15 ` Keith Owens
2000-12-17 10:01 ` David Woodhouse
2000-12-17 10:32 ` Keith Owens
2000-12-17 10:44 ` David Woodhouse [this message]
2000-12-17 10:51 ` Keith Owens
2000-12-17 11:39 ` David Woodhouse
2000-12-17 11:54 ` Keith Owens
2000-12-17 12:04 ` David Woodhouse
2000-12-17 15:20 ` Alan Cox
2000-12-17 16:32 ` Horst von Brand
2000-12-18 7:47 ` Peter Samuelson
2000-12-17 10:27 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.30.0012171039400.14423-100000@imladris.demon.co.uk \
--to=dwmw2@infradead.org \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=rasmus@jaquet.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).