From: Kai Germaschewski <kai@thphy.uni-duesseldorf.de>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Gerold Jury <geroldj@grips.com>,
Linus Torvalds <torvalds@transmeta.com>,
Kernel Mailing List <linux-kernel@vger.kernel.org>,
<dl8bcu@gmx.net>, <Maik.Zumstrull@gmx.de>
Subject: Re: Happy new year^H^H^H^Hkernel..
Date: Wed, 3 Jan 2001 23:06:36 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.30.0101032201290.8073-100000@vaio> (raw)
In-Reply-To: <m17l4cjzig.fsf@frodo.biederman.org>
On 3 Jan 2001, Eric W. Biederman wrote:
> Kai Germaschewski <kai@thphy.uni-duesseldorf.de> writes:
>
> > I think the problem was that we relied on divert_if being initialized to
> > zero automatically, which didn't happen because it was not declared static
> > and therefore not in .bss (*is this true?*).
>
> All variables with static storage (not with static scope) if not explicitly
> initialized are placed in the bss segment. In particular this
> means that adding/removing a static changes nothing.
The patch is right, the explanation was wrong. Sorry, I didn't CC l-k when
I found what was really going on. Other source files used a global
initialized variable "divert_if" as well, so this became the same one as
the one referenced in isdn_common.c. That's why it wasn't zero, it was
explicitly initialized elsewhere. However, making divert_if static in
isdn_common.c fixes the problem, because now it's really local to this
file and therefore initialized to NULL.
--Kai
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2001-01-03 22:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-31 20:24 Happy new year^H^H^H^Hkernel Linus Torvalds
2001-01-01 2:14 ` Adam Sampson
2001-01-01 17:39 ` Linus Torvalds
2001-01-01 19:15 ` Frank Jacobberger
2001-01-01 21:32 ` Keith Owens
2001-01-02 21:18 ` Rik Faith
2001-01-02 21:37 ` Alan Cox
2001-01-02 20:40 ` Adam Sampson
2001-01-01 19:12 ` Daniel Phillips
2001-01-02 2:51 ` Gerold Jury
2001-01-02 11:55 ` Kurt Roeckx
2001-01-02 17:25 ` David Woodhouse
2001-01-02 22:37 ` Gerold Jury
2001-01-02 22:55 ` Kai Germaschewski
2001-01-03 0:38 ` Gerold Jury
2001-01-03 16:07 ` Hugh Dickins
2001-01-03 17:50 ` Eric W. Biederman
2001-01-03 22:06 ` Kai Germaschewski [this message]
2001-01-03 22:32 ` Russell King
2001-01-04 12:03 ` Eric W. Biederman
2001-01-02 18:14 ` Matthias Andree
2001-01-02 18:32 ` Richard B. Johnson
2001-01-02 21:44 ` Andrzej Krzysztofowicz
2001-01-02 18:53 ` Dominik Kubla
2001-01-01 0:16 Ray Strode
2001-01-01 2:56 Ray Strode
[not found] <20010102190651.C26503@Marvin.DL8BCU.ampr.org>
2001-01-02 21:16 ` Kai Germaschewski
[not found] <3A522A57.3050307@grips.com>
2001-01-03 0:37 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.30.0101032201290.8073-100000@vaio \
--to=kai@thphy.uni-duesseldorf.de \
--cc=Maik.Zumstrull@gmx.de \
--cc=dl8bcu@gmx.net \
--cc=ebiederm@xmission.com \
--cc=geroldj@grips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).