archive mirror
 help / color / mirror / Atom feed
From: Stephen Shirley <>
To: Alan Cox <>
Cc: <>, <>
Subject: Re: [PATCH] Some error checking on kmalloc()'s in ide-probe.c
Date: Fri, 15 Jun 2001 11:07:56 +0100 (IST)	[thread overview]
Message-ID: <Pine.LNX.4.32.0106151100120.15645-100000@skynet> (raw)
In-Reply-To: <>

On Thu, 14 Jun 2001, Alan Cox wrote:

> These are already fixed in the -ac tree
> Please people - check the -ac tree before wasting time on these

Hmm - I did indeed forget to check the -ac tree, I have done so now, and
there is no difference between the vanilla kernel and the -ac one in
those places that i can see. The second fix is not needed after closer
inspection (mea culpa), but the first is still valid AFAICS.

Ps. Apologise if I've fumbled it again.

--- ide-probe.c.orig    Thu Jun 14 14:05:31 2001
+++ ide-probe.c Fri Jun 15 11:03:17 2001
@@ -58,6 +58,11 @@
        struct hd_driveid *id;

        id = drive->id = kmalloc (SECTOR_WORDS*4, GFP_ATOMIC);  /* called with interrupts disabled! */
+       if(id == NULL)
+       {
+               printk(KERN_ERR "ide-probe: Failed to allocate memory for hd_driveid struct, aborting\n");
+               return;
+       }
        ide_input_data(drive, id, SECTOR_WORDS);                /* read 512 bytes of id info */
        ide__sti();     /* local CPU only */

"My mom had Windows at work and it hurt her eyes real bad"

      reply	other threads:[~2001-06-15 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-14 13:34 Stephen Shirley
2001-06-14 17:17 ` Alan Cox
2001-06-15 10:07   ` Stephen Shirley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.32.0106151100120.15645-100000@skynet \ \ \ \ \
    --subject='Re: [PATCH] Some error checking on kmalloc()'\''s in ide-probe.c' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).