From: Riley Williams <rhw@MemAlpha.CX>
To: Russell King <rmk@arm.linux.org.uk>
Cc: Keith Owens <kaos@ocs.com.au>,
Adam J Richter <adam@yggdrasil.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Re: 2.4.6p6: dep_{bool,tristate} $CONFIG_ARCH_xxx bugs
Date: Mon, 2 Jul 2001 13:40:25 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.33.0107021326340.13114-100000@infradead.org> (raw)
In-Reply-To: <20010702104134.A28123@flint.arm.linux.org.uk>
Hi Russell.
>> Q> dep_arch_tristate ' AM79C961A support' CONFIG_ARM_AM79C961A \
>> Q> ACORN $CONFIG_NET_ETHERNET
> Before we go and create a patch for Linus to apply...
Who's sent a patch to Linus? I haven't, and don't intend to do so.
> ...please note that the above is totally bogus and is in fact
> 100% wrong.
Please explain? I don't see the problem with the proposed syntax, and
presume you have noticed that it's a new statement type, not a
modification to an existing one?
> Don't create a patch yourself. Let me know how you propose to do
> it, and I will create the patch using the correct symbols.
OK, here's the proposal:
1. Define new config statements that take as their parameters the
following:
1. The prompt text.
2. The name of the config variable to set.
3. The NAME of the config variable that defines the
required architecture.
4. The VALUES of all other config variables this variable
depends on.
2. Define the new `dep_arch_bool` statement to be the same as
`dep_bool` if passed items 1, 2 and 4 when the config var
named in item 3 has the value "y". When the config var named
has any other value, it becomes `define_bool "$2" "n" instead.
3. Define the new `dep_arch_tristate` similarly.
> Also note that the majority of the machine-dependent symbols for
> StrongARM platforms (of which there are around 43) start
> CONFIG_SA1100_*, not CONFIG_ARCH_*. Unfortunately, its far too
> late to get around this special case (I'm not too happy that we
> have this special case either, so don't whinge at me please).
First, why is it "far too late" as you put it? It won't be the first
time config vars have been renamed, and it's unlikely to be the last
either...
Secondly, that isn't a problem to this proposal. The reason for taking
the CONFIG_ARCH_ out of the syntax is to emphasise that it's the name
and not the value that goes in there, thus reducing the likelihood of
problems creeping in in the first place.
Best wishes from Riley.
next prev parent reply other threads:[~2001-07-02 12:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-30 14:57 linux-2.4.6-pre6: numerous dep_{bool,tristate} $CONFIG_ARCH_xxx bugs Adam J. Richter
2001-06-30 15:01 ` Russell King
2001-06-30 20:36 ` 2.4.6p6: " Riley Williams
2001-07-01 3:00 ` Keith Owens
2001-07-01 23:04 ` [PATCH] Re: 2.4.6p6: " Riley Williams
2001-07-02 0:39 ` Keith Owens
2001-07-02 7:16 ` Riley Williams
2001-07-02 7:23 ` Keith Owens
2001-07-02 8:25 ` Riley Williams
2001-07-02 9:41 ` Russell King
2001-07-02 12:40 ` Riley Williams [this message]
2001-07-02 15:03 ` Russell King
2001-07-02 16:28 ` Nicolas Pitre
2001-07-01 2:39 ` linux-2.4.6-pre6: numerous " Keith Owens
2001-07-02 2:25 [PATCH] Re: 2.4.6p6: " Adam J. Richter
2001-07-02 2:48 ` Keith Owens
2001-07-02 7:22 ` Riley Williams
2001-07-02 3:34 Adam J. Richter
2001-07-02 4:46 Adam J. Richter
2001-07-02 4:51 ` Keith Owens
2001-07-02 9:29 ` Andrzej Krzysztofowicz
2001-07-02 5:52 Adam J. Richter
2001-07-02 6:21 ` Keith Owens
2001-07-02 10:14 ` Alan Cox
2001-07-02 6:03 Adam J. Richter
2001-07-02 9:29 Adam J. Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33.0107021326340.13114-100000@infradead.org \
--to=rhw@memalpha.cx \
--cc=adam@yggdrasil.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).