From: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: linux/macros.h(new) and linux/list.h(mod) ...
Date: Fri, 6 Jul 2001 00:03:24 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.33.0107052357190.1054-100000@vaio> (raw)
In-Reply-To: <XFMail.20010705135733.davidel@xmailserver.org>
On Thu, 5 Jul 2001, Davide Libenzi wrote:
> This patch add a new linux/macros.h that is supposed to host utility macros
> that otherwise developers are forced to define in their files.
> This version contain only min(), max() and abs().
It's a good old tradition to put macros in uppercase letters. This would
have avoided one fatal error in your patch, the conflict with the gcc
built-in
int abs(int);
which has it's prototype in include/linux/kernel.h. There's places which
depend on this and would break with your macro.
Also, unless you have more macros in mind, it may make sense to just place
MIN, MAX in kernel.h and of course to remove similar macro definitions
throughout the kernel and replace them by the commonly defined ones.
--Kai
prev parent reply other threads:[~2001-07-05 22:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-05 20:57 linux/macros.h(new) and linux/list.h(mod) Davide Libenzi
2001-07-05 21:31 ` David Woodhouse
2001-07-05 21:45 ` Davide Libenzi
2001-07-05 21:54 ` Hua Zhong
2001-07-05 21:58 ` David Woodhouse
2001-07-05 22:20 ` Hua Zhong
2001-07-05 22:06 ` Davide Libenzi
2001-07-05 22:10 ` J . A . Magallon
2001-07-05 22:33 ` Daniel Phillips
2001-07-05 22:43 ` David Woodhouse
2001-07-05 22:53 ` Davide Libenzi
2001-07-05 23:23 ` J . A . Magallon
2001-07-05 22:57 ` Alan Cox
2001-07-05 23:05 ` Matthew Dharm
2001-07-05 23:07 ` Alan Cox
2001-07-05 23:08 ` David Woodhouse
2001-07-06 1:51 ` Arnaldo Carvalho de Melo
2001-07-05 23:21 ` Davide Libenzi
[not found] ` <0107060149080M.03760@starship>
2001-07-05 23:54 ` Daniel Phillips
2001-07-06 17:38 ` Neil Booth
2001-07-06 22:02 ` Arnaldo Carvalho de Melo
2001-07-05 22:03 ` Kai Germaschewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33.0107052357190.1054-100000@vaio \
--to=kai@tp1.ruhr-uni-bochum.de \
--cc=davidel@xmailserver.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).