From: Linus Torvalds <torvalds@transmeta.com>
To: Rik van Riel <riel@conectiva.com.br>
Cc: Daniel Phillips <phillips@bonn-fries.net>,
Ben LaHaise <bcrl@redhat.com>, <linux-kernel@vger.kernel.org>,
<linux-mm@kvack.org>
Subject: Re: [RFC][DATA] re "ongoing vm suckage"
Date: Fri, 3 Aug 2001 20:35:14 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.33.0108032030430.15155-100000@penguin.transmeta.com> (raw)
In-Reply-To: <Pine.LNX.4.33L.0108040022110.2526-100000@imladris.rielhome.conectiva>
On Sat, 4 Aug 2001, Rik van Riel wrote:
> On Fri, 3 Aug 2001, Linus Torvalds wrote:
>
> > Please just remove the code instead. I don't think it buys you anything.
>
> IIRC you applied the patch introducing that logic because it
> gave a 25% performance increase under some write intensive
> loads (or something like that).
That's the batching code, which is somewhat intertwined with the same
code.
The batching code is a separate issue: when we free the requests, we don't
actually make them available as they get free'd (because then the waiters
will trickle out new requests one at a time and cannot do any merging
etc).
Also, the throttling code probably _did_ make behaviour nicer back when
"sync()" used to use ll_rw_block(). Of course, now most of the IO layer
actually uses "submit_bh()" and bypasses this code completely, so only the
ones that still use it get hit by the unfairness. What a double whammy ;)
Linus
next prev parent reply other threads:[~2001-08-04 3:38 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-03 23:44 [RFC][DATA] re "ongoing vm suckage" Ben LaHaise
2001-08-04 1:29 ` Rik van Riel
2001-08-04 3:06 ` Daniel Phillips
2001-08-04 3:13 ` Linus Torvalds
2001-08-04 3:23 ` Rik van Riel
2001-08-04 3:35 ` Linus Torvalds [this message]
2001-08-04 3:26 ` Ben LaHaise
2001-08-04 3:34 ` Rik van Riel
2001-08-04 3:38 ` Linus Torvalds
2001-08-04 3:48 ` Linus Torvalds
2001-08-04 4:14 ` Ben LaHaise
2001-08-04 4:20 ` Linus Torvalds
2001-08-04 4:39 ` Ben LaHaise
2001-08-04 4:47 ` Linus Torvalds
2001-08-04 5:13 ` Ben LaHaise
2001-08-04 5:28 ` Linus Torvalds
2001-08-04 6:37 ` Linus Torvalds
2001-08-04 5:38 ` Marcelo Tosatti
2001-08-04 7:13 ` Rik van Riel
2001-08-04 14:22 ` Mike Black
2001-08-04 17:08 ` Linus Torvalds
2001-08-05 4:19 ` Michael Rothwell
2001-08-05 18:40 ` Marcelo Tosatti
2001-08-05 20:20 ` Linus Torvalds
2001-08-05 20:45 ` arjan
2001-08-06 20:32 ` Rob Landley
2001-08-05 15:24 ` Mike Black
2001-08-05 20:04 ` Linus Torvalds
2001-08-05 20:23 ` Alan Cox
2001-08-05 20:33 ` Linus Torvalds
2001-08-04 16:21 ` Mark Hemment
2001-08-07 15:45 ` Ben LaHaise
2001-08-07 16:22 ` Linus Torvalds
2001-08-07 16:51 ` Ben LaHaise
2001-08-07 17:08 ` Linus Torvalds
2001-08-07 18:17 ` Andrew Morton
2001-08-07 18:40 ` Ben LaHaise
2001-08-07 21:33 ` Daniel Phillips
2001-08-07 22:03 ` Linus Torvalds
2001-08-07 21:33 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33.0108032030430.15155-100000@penguin.transmeta.com \
--to=torvalds@transmeta.com \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=phillips@bonn-fries.net \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).