linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ignacio Vazquez-Abrams <ignacio@openservices.net>
To: Chris Friesen <cfriesen@nortelnetworks.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] (comments requested) adding finer-grained timing to PPC add_timer_randomness()
Date: Wed, 22 Aug 2001 17:06:31 -0400 (EDT)	[thread overview]
Message-ID: <Pine.LNX.4.33.0108221702300.12521-100000@terbidium.openservices.net> (raw)
In-Reply-To: <3B841CC3.E7040002@nortelnetworks.com>

On Wed, 22 Aug 2001, Chris Friesen wrote:

> I'd like some comments on the following patch.
>
> This patch is designed to add finer-grained timing (similar to the i386 timing)
> to add_timer_randomness().  The only tricky bit is that the PPC601 doesn't
> support the timebase registers.  Accordingly, I've added a flag to the PPC port
> that is used to keep track of whether or not the processor supports the timebase
> register.
>
> Is there a better way to keep track of this information?  i386 has a struct with
> useful information stored, but it doesn't look like PPC does.
>
> Thanks,
>
> Chris

>From the patch:

--- linux-2.2.19-clean/arch/ppc/kernel/setup.c  Sun Mar 25 11:31:49 2001
+++ linux-2.2.19/arch/ppc/kernel/setup.c        Wed Aug 22 16:34:51 2001
  ...
+extern int have_timebase = 1;
  ...
--- linux-2.2.19-clean/include/asm-ppc/processor.h      Sun Mar 25 11:31:08 2001
+++ linux-2.2.19/include/asm-ppc/processor.h    Wed Aug 22 16:34:51 2001
  ...
+extern int have_timebase;
  ...

Hrmm...

Am I missing something, or should at least one of these not be extern?

-- 
Ignacio Vazquez-Abrams  <ignacio@openservices.net>









  reply	other threads:[~2001-08-22 21:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-22 20:57 [PATCH] (comments requested) adding finer-grained timing to PPC add_timer_randomness() Chris Friesen
2001-08-22 21:06 ` Ignacio Vazquez-Abrams [this message]
2001-08-22 21:27   ` Chris Friesen
2001-08-23  1:33   ` Paul Mackerras
2001-08-23  9:46     ` Gabriel Paubert
2001-08-23 13:11       ` Benjamin Herrenschmidt
2001-08-23 12:31     ` Paul Mackerras
2001-08-24  7:32       ` Gabriel Paubert
2001-08-24 13:59         ` Christopher Friesen
2001-08-28 20:50           ` Gabriel Paubert
2001-08-24 17:54         ` [PATCH] (comments requested) adding finer-grained timing to PPC Albert D. Cahalan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.33.0108221702300.12521-100000@terbidium.openservices.net \
    --to=ignacio@openservices.net \
    --cc=cfriesen@nortelnetworks.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).