From: Linus Torvalds <torvalds@transmeta.com>
To: Andreas Bombe <andreas.bombe@munich.netsurf.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] yenta resource allocation fix
Date: Wed, 29 Aug 2001 06:48:26 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.33.0108290645140.8173-100000@penguin.transmeta.com> (raw)
In-Reply-To: <20010829013318.A16910@storm.local>
On Wed, 29 Aug 2001, Andreas Bombe wrote:
>
> I have no idea why the 0xfff was in place. Or, on second thought, this
> might be to allocate memory space behind official end as slack? This
> would defy the end > start check then, anyway. Linus?
I've looked more at the issue.
0xfff is definitely right for memory windows and is generally right for
PCI-PCI bridges too - they cannot have IO or memory windows that are
anything but 4kB aligned.
But it turns out that the Yenta specification actually expanded on the
PCI-PCI bridge window specs for IO space - a Yenta bridge is supposed to
be able to handle IO windows at 4-byte granularity, not the 4kB a regular
PCI bridge does.
Does this alternate patch work for you?
Linus
------
diff -u --recursive --new-file pre2/linux/drivers/pcmcia/yenta.c linux/drivers/pcmcia/yenta.c
--- pre2/linux/drivers/pcmcia/yenta.c Wed Aug 29 06:20:01 2001
+++ linux/drivers/pcmcia/yenta.c Wed Aug 29 06:13:40 2001
@@ -702,6 +702,12 @@
u32 start, end;
u32 align, size, min, max;
unsigned offset;
+ unsigned mask;
+
+ /* The granularity of the memory limit is 4kB, on IO it's 4 bytes */
+ mask = ~0xfff;
+ if (type & IORESOURCE_IO)
+ mask = ~3;
offset = 0x1c + 8*nr;
bus = socket->dev->subordinate;
@@ -715,8 +721,8 @@
if (!root)
return;
- start = config_readl(socket, offset);
- end = config_readl(socket, offset+4) | 0xfff;
+ start = config_readl(socket, offset) & mask;
+ end = config_readl(socket, offset+4) | ~mask;
if (start && end > start) {
res->start = start;
res->end = end;
diff -u --recursive --new-file pre2/linux/mm/vmscan.c linux/mm/vmscan.c
--- pre2/linux/mm/vmscan.c Wed Aug 15 02:37:07 2001
+++ linux/mm/vmscan.c Wed Aug 29 06:02:46 2001
@@ -818,10 +818,12 @@
#define GENERAL_SHORTAGE 4
static int do_try_to_free_pages(unsigned int gfp_mask, int user)
{
- /* Always walk at least the active queue when called */
- int shortage = INACTIVE_SHORTAGE;
+ int shortage = 0;
int maxtry;
+ /* Always walk at least the active queue when called */
+ refill_inactive_scan(DEF_PRIORITY);
+
maxtry = 1 << DEF_PRIORITY;
do {
/*
@@ -872,7 +874,8 @@
break;
} while (shortage);
- return !shortage;
+ /* Return success if we're not "totally short" */
+ return shortage != FREE_SHORTAGE | INACTIVE_SHORTAGE | GENERAL_SHORTAGE;
}
DECLARE_WAIT_QUEUE_HEAD(kswapd_wait);
next prev parent reply other threads:[~2001-08-29 13:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-28 23:33 [PATCH] yenta resource allocation fix Andreas Bombe
2001-08-29 1:23 ` Linus Torvalds
2001-08-29 13:48 ` Linus Torvalds [this message]
2001-08-29 21:20 ` Andreas Bombe
-- strict thread matches above, loose matches on Subject: below --
2001-08-26 22:58 Andreas Bombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33.0108290645140.8173-100000@penguin.transmeta.com \
--to=torvalds@transmeta.com \
--cc=andreas.bombe@munich.netsurf.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).