linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: <linux-kernel@vger.kernel.org>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Arjan van de Ven <arjanv@redhat.com>,
	Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>, <netdev@oss.sgi.com>
Subject: [patch] auto-limiting IRQ load take #2, irq-rewrite-2.4.11-F4
Date: Wed, 3 Oct 2001 16:51:47 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.33.0110031625330.7342-101000@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.33.0110022122310.2328-101000@localhost.localdomain>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1178 bytes --]


the attached patch contains a cleaned up version of IRQ auto-mitigation.

- i've removed the max_rate limit and have streamlined the impact of the
  load-estimator on do_IRQ() to this piece of code:

        desc->total_contexts++;
        if (unlikely(in_interrupt()))
                goto mitigate_irqload;

  i dont think we can get much cheaper than this. (We could perhaps avoid
  the total_contexts counter by saving a 'snapshot' of the existing
  kstat.irqs array of counters in every timer tick and comparing the
  snapshot to the current kstat.irqs values. That looked pretty unclean
  though.)

- the per-cpu irq counting in -D9 was incorrect as it collapsed all irq
  handlers into a single counter.

- i've removed the net-polling hacks - they are unrelated to this problem.

the patch is against 2.4.11-pre2. (the eepro100.c fixes from the -ac tree
are already included in -pre2, i only included them in this patch to make
patching & testing against 2.4.10 easier.).

(i'd like to stress the point again that the goal of this approach is
*not* to be nice. This is an airbag mechanizm, it can and will hurt
performance. But my box does not lock up anymore.)

	Ingo

[-- Attachment #2: Type: APPLICATION/x-bzip2, Size: 10395 bytes --]

  reply	other threads:[~2001-10-03 14:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-01 22:16 [announce] [patch] limiting IRQ load, irq-rewrite-2.4.11-B5 Ingo Molnar
2001-10-01 22:26 ` Tim Hockin
2001-10-01 22:50   ` Ingo Molnar
2001-10-01 22:36 ` Andreas Dilger
2001-10-01 22:50 ` Ben Greear
2001-10-02 14:30   ` Alan Cox
2001-10-02 20:51     ` Ingo Molnar
2001-10-01 23:03 ` Linus Torvalds
2001-10-02 20:34   ` [patch] auto-limiting IRQ load, IRQ-polling, irq-rewrite-2.4.11-D9 Ingo Molnar
2001-10-03 14:51     ` Ingo Molnar [this message]
2001-10-03 15:16       ` [patch] auto-limiting IRQ load take #2, irq-rewrite-2.4.11-F4 jamal
2001-10-03 16:51         ` Rik van Riel
2001-10-02  6:50 ` [announce] [patch] limiting IRQ load, irq-rewrite-2.4.11-B5 Marcus Sundberg
2001-10-03  8:47   ` Ingo Molnar
2001-10-03 16:23 [patch] auto-limiting IRQ load take #2, irq-rewrite-2.4.11-F4 Manfred Spraul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.33.0110031625330.7342-101000@localhost.localdomain \
    --to=mingo@elte.hu \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=arjanv@redhat.com \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).