linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@transmeta.com>
To: Lorenzo Allegrucci <lenstra@tiscalinet.it>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: VM: qsbench numbers
Date: Sun, 4 Nov 2001 17:03:40 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.33.0111041657060.14237-100000@penguin.transmeta.com> (raw)
In-Reply-To: <3.0.6.32.20011104221747.01ff8d30@pop.tiscalinet.it>


On Sun, 4 Nov 2001, Lorenzo Allegrucci wrote:
> >
> >Does "free" after a run has completed imply that there's still lots of
> >swap used? We _should_ have gotten rid of it at "free_swap_and_cache()"
> >time, but if we missed it..
>
> 70.590u 7.640s 2:31.06 51.7%    0+0k 0+0io 19036pf+0w
> lenstra:~/src/qsort> free
>              total       used       free     shared    buffers     cached
> Mem:        255984       6008     249976          0        100       1096
> -/+ buffers/cache:       4812     251172
> Swap:       195512       5080     190432

That's not a noticeable amount, and is perfectly explainable by simply
having deamons that got swapped out with truly inactive pages. So a
swapcache leak does not seem to be the reason for the unstable numbers.

> >What happens if you make the "vm_swap_full()" define in <linux/swap.h> be
> >unconditionally defined to "1"?
>
> 70.530u 7.290s 2:33.26 50.7%    0+0k 0+0io 19689pf+0w
> 70.830u 7.100s 2:29.52 52.1%    0+0k 0+0io 18488pf+0w
> 70.560u 6.840s 2:28.66 52.0%    0+0k 0+0io 18203pf+0w
>
> Performace improved and numbers stabilized.

Indeed.

Mind doing some more tests? In particular, the "vm_swap_full()" macro is
only used in two places: mm/memory.c and mm/swapfile.c. Are you willing to
test _which_ one (or is it both together) it is that seems to bring on the
unstable numbers?

		Linus


  reply	other threads:[~2001-11-05  1:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.33.0111040913370.6919-100000@penguin.transmeta. com>
2001-11-04 14:11 ` VM: qsbench numbers Lorenzo Allegrucci
2001-11-04 17:18   ` Linus Torvalds
2001-11-04 21:17   ` Lorenzo Allegrucci
2001-11-05  1:03     ` Linus Torvalds [this message]
2001-11-05 15:30 Lorenzo Allegrucci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.33.0111041657060.14237-100000@penguin.transmeta.com \
    --to=torvalds@transmeta.com \
    --cc=lenstra@tiscalinet.it \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).