From: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
To: Adam Kropelin <akropel1@rochester.rr.com>
Cc: linux-kernel@vger.kernel.org, <davej@suse.de>
Subject: Re: [RFC][PATCH] cpqarray-1: Convert to modern module_init mechanism
Date: Fri, 17 May 2002 09:35:31 -0500 (CDT) [thread overview]
Message-ID: <Pine.LNX.4.44.0205170929350.26436-100000@chaos.physics.uiowa.edu> (raw)
In-Reply-To: <20020517005146.GA32719@www.kroptech.com>
On Thu, 16 May 2002, Adam Kropelin wrote:
> Below is a patch (against 2.5.15-dj1) to convert cpqarray over to the modern
> module_init mechanism. This eliminates the need to call cpqarray_init() from
> genhd.c and starts the process of simplifying the cpqarray init sequence.
> It lays the groundwork for converting over to the "new" PCI registration
> mechanism as well. Also included in the patch are some simple cleanups for
> a few obvious formatting flaws.
>
> Comments and critique are welcome. I'm also curious if this work is
> considered worthwhile. If so, I'll continue on and do the PCI init conversion
> (and any other fixups that may be warranted) as well.
Patch looks basically good to me (I basically have the same thing sitting
around here, as I was cleaning up drivers/block/genhd.c) If you want to I
can send you what I have, so you can base the further changes (e.g. PCI)
on it.
--Kai
> /*
> * This is it. Find all the controllers and register them. I really hate
> * stealing all these major device numbers.
> - * returns the number of block devices registered.
> + * returns 0 on success, -EIO on failure
I'd suggest to go ahead and make it return sensible values, i.e. -EBUSY if
it can't get the major, -ENODEV if there's no hardware, -ENOMEM if the
allocations fail.
> int __init cpqarray_init(void)
This should be static now. Also, you need to remove the explicit call to
cpqarray_init() from drivers/block/genhd.c, otherwise it'll get called
twice. (That part's already in my patch).
--Kai
next prev parent reply other threads:[~2002-05-17 14:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-17 0:51 [RFC][PATCH] cpqarray-1: Convert to modern module_init mechanism Adam Kropelin
2002-05-17 4:35 ` Keith Owens
2002-05-17 15:40 ` Adam Kropelin
2002-05-17 14:35 ` Kai Germaschewski [this message]
2002-05-17 15:39 ` Adam Kropelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0205170929350.26436-100000@chaos.physics.uiowa.edu \
--to=kai@tp1.ruhr-uni-bochum.de \
--cc=akropel1@rochester.rr.com \
--cc=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).