From: Thunder from the hill <thunder@lightweight.ods.org>
To: Robert Love <rml@tech9.net>
Cc: torvalds@transmeta.com, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] make raid5 checksums preempt-safe
Date: Mon, 26 Aug 2002 15:09:43 -0600 (MDT) [thread overview]
Message-ID: <Pine.LNX.4.44.0208261507590.3234-100000@hawkeye.luckynet.adm> (raw)
In-Reply-To: <1030392363.905.418.camel@phantasy>
Hi,
On 26 Aug 2002, Robert Love wrote:
> @@ -543,6 +545,7 @@
> #define XMMS_SAVE \
> + preempt_disable(); \
> __asm__ __volatile__ ( \
> "movl %%cr0,%0 ;\n\t" \
> "clts ;\n\t" \
> @@ -564,7 +567,8 @@
> "movl %0,%%cr0 ;\n\t" \
> : \
> : "r" (cr0), "r" (xmm_save) \
> - : "memory")
> + : "memory") \
> + preempt_enable();
> @@ -38,7 +38,8 @@
> #define XMMS_SAVE \
> - asm volatile ( \
> + preempt_disable(); \
> + asm volatile ( \
> "movq %%cr0,%0 ;\n\t" \
> "clts ;\n\t" \
> "movups %%xmm0,(%1) ;\n\t" \
> @@ -59,7 +60,8 @@
> "movq %0,%%cr0 ;\n\t" \
> : \
> : "r" (cr0), "r" (xmm_save) \
> - : "memory")
> + : "memory") \
> + preempt_enable();
These will suck when on if, I guess... Anyway, will this compile at all?
There seems no semicolon after the asm volatile ()
Thunder
--
--./../...-/. -.--/---/..-/.-./..././.-../..-. .---/..-/.../- .-
--/../-./..-/-/./--..-- ../.----./.-../.-.. --./../...-/. -.--/---/..-
.- -/---/--/---/.-./.-./---/.--/.-.-.-
--./.-/-.../.-./.././.-../.-.-.-
next prev parent reply other threads:[~2002-08-26 21:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-26 20:06 [PATCH] make raid5 checksums preempt-safe Robert Love
2002-08-26 21:09 ` Thunder from the hill [this message]
2002-08-26 21:15 ` Robert Love
2002-08-27 1:38 ` Horst von Brand
2002-08-27 15:25 ` Thunder from the hill
2002-08-27 15:34 ` How can a process easily get a list of all it's open fd? Mark Atwood
2002-08-27 16:08 ` Alex Riesen
2002-08-27 21:26 ` Mike Touloumtzis
2002-08-28 8:28 ` Alex Riesen
2002-08-27 23:21 ` DervishD
2002-08-26 22:33 ` [PATCH] make raid5 checksums preempt-safe Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0208261507590.3234-100000@hawkeye.luckynet.adm \
--to=thunder@lightweight.ods.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rml@tech9.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).