From: Linus Torvalds <torvalds@transmeta.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Linux FSdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Introduce BSD-style user credential [3/3]
Date: Fri, 30 Aug 2002 16:40:53 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.44.0208301634580.5430-100000@home.transmeta.com> (raw)
In-Reply-To: <15727.64653.78081.277222@charged.uio.no>
Hmm..
your <linux/cred.h> file exposes "struct ucred" to user space (or at
least has a #ifdef __KERNEL__ that does not protect it). Why?
Also, I don't see how this is going to solve the credential clone problem,
which basically says that sometimes you do _not_ want to do COW on the
credentials (when changing them when they are shared with other threads)
and sometimes you do (when changing them when they are shared with a
background filesystem lookup).
Any ideas on that?
(And I _really_ don't like those trivial inline functions in [1/3] - I
think it's much better to just show that we're doing a pointer dereference
than trying to hide it behind some silly "current_fsuid()" inline
function).
Linus
next prev parent reply other threads:[~2002-08-30 23:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-30 23:15 [PATCH] Introduce BSD-style user credential [3/3] Trond Myklebust
2002-08-30 23:40 ` Linus Torvalds [this message]
2002-08-31 0:24 ` Trond Myklebust
2002-08-31 0:49 ` Linus Torvalds
2002-08-31 0:51 ` Alan Cox
2002-08-31 0:56 ` Trond Myklebust
2002-08-31 1:01 ` Chris Wright
2002-08-31 1:04 ` Linus Torvalds
2002-08-31 16:13 ` Daniel Phillips
2002-08-31 16:43 ` Alan Cox
2002-08-31 1:29 ` Trond Myklebust
2002-08-31 4:18 ` Linus Torvalds
2002-08-31 12:02 ` Kai Henningsen
2002-08-31 16:30 ` Trond Myklebust
2002-09-01 15:23 ` Daniel Phillips
2002-08-31 19:06 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0208301634580.5430-100000@home.transmeta.com \
--to=torvalds@transmeta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).