linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Mochel <mochel@osdl.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andre Hedrick <andre@linux-ide.org>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: devicefs & sleep support for IDE
Date: Mon, 23 Sep 2002 11:42:21 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.44.0209231136100.6409-100000@cherise.pdx.osdl.net> (raw)
In-Reply-To: <20020921210456.GA31784@elf.ucw.cz>


> New patch, rediffed against 2.5.36.
> 
> More patches will be needed to support IDE properly (like DVD burners
> you mentioned), but this is known to fix data corruption. It has zero
> impact on actual I/O. It affects initialization and suspend only.
> Please apply this time.

Basic driver model support for IDE is in 2.5.38. This just involves 
creating an IDE bus type, and registering drives as devices. I.e. there is 
no driver set for any of the drives. 

I do have a couple of comments though.

> +static struct device_driver idedisk_devdrv = {
> +	.lock = RW_LOCK_UNLOCKED,
> +	.suspend = idedisk_suspend,
> +	.resume = idedisk_resume,
> +};

You don't need to initialize .lock. But, you do need a .name and .bus. The 
driver won't even be registered unless .bus is set. 

> @@ -835,6 +837,7 @@
>  	int		crc_count;	/* crc counter to reduce drive speed */
>  	struct list_head list;
>  	struct gendisk *disk;
> +	struct device	device;		/* for driverfs */
>  } ide_drive_t;

There is a struct device in struct gendisk; that should suffice. But note 
that you may have to do an extra conversion in order to access it in the 
driver callbacks. 

> +	struct device	device;		/* for devicefs */

Please: it's driver model support, not driverfs. And devicefs does not 
even exist. :)


Thanks,

	-pat


  reply	other threads:[~2002-09-23 18:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-21 21:04 devicefs & sleep support for IDE Pavel Machek
2002-09-23 18:42 ` Patrick Mochel [this message]
2002-09-23 21:24   ` Pavel Machek
2002-09-25 16:44     ` Patrick Mochel
2002-09-26 14:14       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0209231136100.6409-100000@cherise.pdx.osdl.net \
    --to=mochel@osdl.org \
    --cc=andre@linux-ide.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).