archive mirror
 help / color / mirror / Atom feed
From: Patrick Mochel <>
To: Pavel Machek <>
Cc: kernel list <>
Subject: Re: devicefs & sleep support for IDE
Date: Wed, 25 Sep 2002 09:44:41 -0700 (PDT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

> Questions: is it possible that in hwif_register you don't need to
> initialize parent?

Actually, looking at it again, the struct device in hwif_t should probably 
go away. We should initialize the parent device to the struct device in 
the struct pci_dev of the controller; at least for PCI controllers.

For non-PCI controllers, is there anything else that describes the 
controller besides hwif_t ?

> Where is device_put of hwif->gendev? I miss it.

There is none (yet), as there is no driver attached to it. If we remove it 
in favor of the PCI device, then we get it in the pci driver for the 
controller; and we'd need one for non-PCI controllers.

> Ouch. There are actually two devices in struct gendisk. I choosed
> disk_dev. Was it right?

Yes. The other one: 

	struct device *driverfs_dev;

was from the SCSI people. I think they had good intentions, but I'm not 
sure what they were doing in several places (including here).


  reply	other threads:[~2002-09-25 16:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-21 21:04 devicefs & sleep support for IDE Pavel Machek
2002-09-23 18:42 ` Patrick Mochel
2002-09-23 21:24   ` Pavel Machek
2002-09-25 16:44     ` Patrick Mochel [this message]
2002-09-26 14:14       ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).