From: Zwane Mwaikambo <zwane@linuxpower.ca>
To: Dipankar Sarma <dipankar@in.ibm.com>
Cc: William Lee Irwin III <wli@holomorphy.com>,
Andrew Morton <akpm@digeo.com>,
lkml <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: 2.5.38-mm3
Date: Sat, 28 Sep 2002 00:35:30 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44.0209280034101.32347-100000@montezuma.mastecende.com> (raw)
In-Reply-To: <20020927152833.D25021@in.ibm.com>
On Fri, 27 Sep 2002, Dipankar Sarma wrote:
> The counts are off by one.
>
> With a UP kernel, I see that fget() cost is negligible.
> So it is most likely the atomic operations for rwlock acquisition/release
> in fget() that is adding to its cost. Unless of course my sampling
> is too less.
Mine is a UP box not an SMP kernel, although preempt is enabled;
0xc013d370 <fget>: push %ebx
0xc013d371 <fget+1>: mov %eax,%ecx
0xc013d373 <fget+3>: mov $0xffffe000,%edx
0xc013d378 <fget+8>: and %esp,%edx
0xc013d37a <fget+10>: incl 0x4(%edx)
0xc013d37d <fget+13>: xor %ebx,%ebx
0xc013d37f <fget+15>: mov 0x554(%edx),%eax
0xc013d385 <fget+21>: cmp 0x8(%eax),%ecx
0xc013d388 <fget+24>: jae 0xc013d390 <fget+32>
0xc013d38a <fget+26>: mov 0x14(%eax),%eax
0xc013d38d <fget+29>: mov (%eax,%ecx,4),%ebx
0xc013d390 <fget+32>: test %ebx,%ebx
0xc013d392 <fget+34>: je 0xc013d397 <fget+39>
0xc013d394 <fget+36>: incl 0x14(%ebx)
0xc013d397 <fget+39>: decl 0x4(%edx)
0xc013d39a <fget+42>: mov 0x14(%edx),%eax
0xc013d39d <fget+45>: cmp %eax,0x4(%edx)
0xc013d3a0 <fget+48>: jge 0xc013d3a7 <fget+55>
0xc013d3a2 <fget+50>: call 0xc01179b0 <preempt_schedule>
0xc013d3a7 <fget+55>: mov %ebx,%eax
0xc013d3a9 <fget+57>: pop %ebx
0xc013d3aa <fget+58>: ret
0xc013d3ab <fget+59>: nop
0xc013d3ac <fget+60>: lea 0x0(%esi,1),%esi
> Please try running the files_struct_rcu patch where fget() is lockfree
> and let me know what you see.
Lock acquisition/release should be painless on this system no?
Zwane
--
function.linuxpower.ca
next prev parent reply other threads:[~2002-09-28 4:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-26 7:57 2.5.38-mm3 Andrew Morton
2002-09-26 12:24 ` 2.5.38-mm3 Dipankar Sarma
2002-09-26 12:29 ` 2.5.38-mm3 William Lee Irwin III
2002-09-26 12:40 ` 2.5.38-mm3 Dipankar Sarma
2002-09-26 12:42 ` 2.5.38-mm3 William Lee Irwin III
2002-09-26 13:05 ` 2.5.38-mm3 Dipankar Sarma
2002-09-26 13:17 ` 2.5.38-mm3 William Lee Irwin III
2002-09-26 13:29 ` 2.5.38-mm3 Zwane Mwaikambo
2002-09-26 13:39 ` 2.5.38-mm3 William Lee Irwin III
2002-09-26 13:46 ` 2.5.38-mm3 Zwane Mwaikambo
2002-09-27 8:27 ` 2.5.38-mm3 Dipankar Sarma
2002-09-27 9:20 ` 2.5.38-mm3 William Lee Irwin III
2002-09-27 9:58 ` 2.5.38-mm3 Dipankar Sarma
2002-09-27 15:04 ` 2.5.38-mm3 Martin J. Bligh
2002-09-27 17:14 ` 2.5.38-mm3 Dipankar Sarma
2002-09-27 22:54 ` 2.5.38-mm3 William Lee Irwin III
2002-09-28 5:41 ` 2.5.38-mm3 Dipankar Sarma
2002-09-28 4:35 ` Zwane Mwaikambo [this message]
2002-09-28 4:36 ` 2.5.38-mm3 William Lee Irwin III
2002-09-28 4:54 ` 2.5.38-mm3 Zwane Mwaikambo
2002-09-28 5:29 ` 2.5.38-mm3 Dipankar Sarma
2002-09-28 4:30 ` 2.5.38-mm3 Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0209280034101.32347-100000@montezuma.mastecende.com \
--to=zwane@linuxpower.ca \
--cc=akpm@digeo.com \
--cc=dipankar@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).