From: Linus Torvalds <torvalds@transmeta.com>
To: Tim Hockin <thockin@hockin.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.5.41 s390 (8/8): 16 bit uid/gids.
Date: Wed, 9 Oct 2002 15:10:08 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.44.0210091508050.24776-100000@penguin.transmeta.com> (raw)
In-Reply-To: <200210091824.g99IOkI18617@www.hockin.org>
On Wed, 9 Oct 2002, Tim Hockin wrote:
> >
> > In other words, that __UID16 thing should be a real CONFIG_XXX option.
>
> Because Sparc64/s390x/? still need to tell highuid.h to do macro magic for
> NEW_TO_OLD_UID() and friends in some places and not others. A CONFIG_XXX
> applies all the time to all files.
If __UID16 works, then renaming it to CONFIG_UID16_ONLY _must_ also work.
I don't understand your argument about other architectures. I'm claiming
that __UID16 is a config option, and that it must be renamed to _show_
that it is a config option.
If the renaming results in code that doesn't work, then the code didn't
work in the first place or your cpp is incredibly broken.
WE MUST NOT HAVE CONFIG OPTIONS THAT ARE HIDDEN AND CALLED __UID16! That's
my whole point.
Linus
next prev parent reply other threads:[~2002-10-09 22:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-09 12:32 [PATCH] 2.5.41 s390 (8/8): 16 bit uid/gids Martin Schwidefsky
2002-10-09 17:24 ` Linus Torvalds
2002-10-09 17:38 ` Tim Hockin
2002-10-09 17:47 ` Linus Torvalds
2002-10-09 18:24 ` Tim Hockin
2002-10-09 22:10 ` Linus Torvalds [this message]
2002-10-09 22:43 ` Tim Hockin
2002-10-09 23:12 ` Linus Torvalds
2002-10-09 23:38 ` David S. Miller
2002-10-09 23:59 ` Tim Hockin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0210091508050.24776-100000@penguin.transmeta.com \
--to=torvalds@transmeta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=thockin@hockin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).