From: Linus Torvalds <torvalds@transmeta.com>
To: Roland McGrath <roland@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, Anton Blanchard <anton@samba.org>,
Andrew Morton <akpm@digeo.com>,
Arjan van de Ven <arjanv@redhat.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: heavy handed exit() in latest BK
Date: Sun, 9 Feb 2003 17:07:01 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.44.0302091703220.13648-100000@home.transmeta.com> (raw)
In-Reply-To: <200302091156.h19BuoH07869@magilla.sf.frob.com>
On Sun, 9 Feb 2003, Roland McGrath wrote:
>
> There is a similar failure to take the lock before using zap_other_threads.
> I thought I sent this patch before, but it's not in 2.5 yet.
Hmm.. From looking at this patch, it seems as if you believe that
spinlocks must next correctly. They don't have to.
The ABBA kind of deadlock only means that you have to _take_ the spinlocks
in the right order, you can release them in any order you like (as long as
you release all of them).
So if the only requirement is that zap_other_threads() is called with the
tasklist lock held, I would suggest just dropping the tasklist lock after
the zap_other threads thing, despite the fact that you still want to hold
on to the siglock for a while longer. That simplifies the patch, and means
that you don't have to worry about dropping and re-taking the tasklist
lock in the loop that follows.
Linus
next prev parent reply other threads:[~2003-02-10 1:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200302091130.h19BU2107744@magilla.sf.frob.com>
2003-02-09 11:40 ` heavy handed exit() in latest BK Ingo Molnar
2003-02-09 11:56 ` Roland McGrath
2003-02-09 12:09 ` Ingo Molnar
2003-02-09 12:18 ` Ingo Molnar
2003-02-09 12:23 ` Ingo Molnar
2003-02-09 12:22 ` Arjan van de Ven
2003-02-10 1:07 ` Linus Torvalds [this message]
2003-02-10 1:27 ` Roland McGrath
2003-02-09 0:57 Anton Blanchard
2003-02-09 2:00 ` Linus Torvalds
2003-02-09 2:17 ` Roland McGrath
2003-02-09 2:19 ` Linus Torvalds
2003-02-09 2:31 ` Roland McGrath
2003-02-09 2:34 ` Linus Torvalds
2003-02-09 2:33 ` Linus Torvalds
2003-02-09 2:41 ` Roland McGrath
2003-02-09 3:30 ` Roland McGrath
2003-02-09 3:33 ` Roland McGrath
2003-02-09 3:37 ` Linus Torvalds
2003-02-09 3:40 ` Linus Torvalds
2003-02-09 3:48 ` Roland McGrath
2003-02-09 4:51 ` Linus Torvalds
2003-02-09 4:57 ` Linus Torvalds
2003-02-09 5:00 ` Roland McGrath
2003-02-09 9:28 ` Russell King
2003-02-10 8:53 ` Ingo Molnar
2003-02-10 15:22 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0302091703220.13648-100000@home.transmeta.com \
--to=torvalds@transmeta.com \
--cc=akpm@digeo.com \
--cc=anton@samba.org \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).