From: Ingo Molnar <mingo@elte.hu>
To: Rick Lindsley <ricklind@us.ibm.com>
Cc: "Martin J. Bligh" <mbligh@aracnet.com>,
Linus Torvalds <torvalds@transmeta.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: NUMA scheduler broken
Date: Fri, 7 Mar 2003 13:41:50 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.44.0303071339090.10744-100000@localhost.localdomain> (raw)
In-Reply-To: <200303071151.h27BpB415705@owlet.beaverton.ibm.com>
On Fri, 7 Mar 2003, Rick Lindsley wrote:
> Looks like __activate_task() should call nr_running_inc(rq) rather than
> rq->nr_running++, and the same in wake_up_forked_process(). My guess is
> that the bogus node_nr_running value is causing some really poor
> scheduling decisions to be made on NUMA. See if that changes your
> result.
indeed. The attached patch (against BK-curr) fixes this.
Ingo
--- kernel/sched.c.orig 2003-03-07 13:40:53.000000000 +0100
+++ kernel/sched.c 2003-03-07 13:41:19.000000000 +0100
@@ -325,7 +325,7 @@
static inline void __activate_task(task_t *p, runqueue_t *rq)
{
enqueue_task(p, rq->active);
- rq->nr_running++;
+ nr_running_inc(rq);
}
static inline void activate_task(task_t *p, runqueue_t *rq)
@@ -545,7 +545,7 @@
list_add_tail(&p->run_list, ¤t->run_list);
p->array = current->array;
p->array->nr_active++;
- rq->nr_running++;
+ nr_running_inc(rq);
}
task_rq_unlock(rq, &flags);
}
next prev parent reply other threads:[~2003-03-07 12:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-07 8:30 NUMA scheduler broken Martin J. Bligh
2003-03-07 11:51 ` Rick Lindsley
2003-03-07 12:41 ` Ingo Molnar [this message]
2003-03-07 16:24 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0303071339090.10744-100000@localhost.localdomain \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=ricklind@us.ibm.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).