From: Linus Torvalds <torvalds@transmeta.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: [FBDEV BK] Updates and fixes.
Date: Mon, 14 Apr 2003 12:15:35 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.44.0304141209420.19302-100000@home.transmeta.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0304140545010.10446-100000@phoenix.infradead.org>
On Mon, 14 Apr 2003, James Simmons wrote:
>
> Linus, please do a
>
> bk pull http://fbdev.bkbits.net/fbdev-2.5
This seems to cause
arch/i386/boot/setup.o(.text+0x9a4): In function `video':
: undefined reference to `store_edid'
which is apparently because I don't configure VIDEO_SELECT.
I did this to make it compile, but you should check what the real issue
is.
Linus
----
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1034 -> 1.1035
# arch/i386/boot/video.S 1.6 -> 1.7
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/04/14 torvalds@home.transmeta.com 1.1035
# Store EDID only when CONFIG_VIDEO_SELECT is set and edid
# function actually exists.
# --------------------------------------------
#
diff -Nru a/arch/i386/boot/video.S b/arch/i386/boot/video.S
--- a/arch/i386/boot/video.S Mon Apr 14 12:14:46 2003
+++ b/arch/i386/boot/video.S Mon Apr 14 12:14:46 2003
@@ -133,9 +133,9 @@
#ifdef CONFIG_VIDEO_RETAIN
call restore_screen # Restore screen contents
#endif /* CONFIG_VIDEO_RETAIN */
+ call store_edid
#endif /* CONFIG_VIDEO_SELECT */
call mode_params # Store mode parameters
- call store_edid
popw %ds # Restore original DS
ret
next prev parent reply other threads:[~2003-04-14 19:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-14 4:47 [FBDEV BK] Updates and fixes James Simmons
2003-04-14 7:58 ` Andrew Morton
2003-04-14 8:53 ` [Linux-fbdev-devel] " Benjamin Herrenschmidt
2003-04-15 19:25 ` James Simmons
2003-04-15 19:21 ` James Simmons
2003-04-15 20:04 ` Andreas Henriksson
2003-04-16 6:20 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2003-04-14 19:15 ` Linus Torvalds [this message]
2003-04-15 19:49 ` James Simmons
2003-04-23 16:32 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0304141209420.19302-100000@home.transmeta.com \
--to=torvalds@transmeta.com \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).