From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@digeo.com>
Cc: joern@wohnheim.fh-wedel.de, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] stop swapoff 3/3 OOMkill
Date: Fri, 18 Apr 2003 00:10:19 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.44.0304172359320.1178-100000@localhost.localdomain> (raw)
In-Reply-To: <20030417145527.00de9fb6.akpm@digeo.com>
On Thu, 17 Apr 2003, Andrew Morton wrote:
>
> __GFP_NORETRY:
>
> Don't oom-kill and don't retry. For swapoff.
>
> I've implemented a __GFP_REPEAT, and don't like it, because it blurs the
> __GFP_REPEAT and __GFP_NOFAIL requirements. I'll add __GFP_NORETRY and we
> can then pass that into read_swap_cache_async() and handle the error.
>
> Sound good?
Probably not. I did try something like that over a year ago, and it
didn't work as well as I'd expected. One problem, I think, is that
while it's going through pages already in the swap cache, swapoff
may not need to allocate memory itself; but meanwhile other tasks
are trying to allocate memory and getting OOMkilled. I think that
argues that swapoff does need to register itself for the duration
with the OOMkiller: a PF_ flag achieves that but a __GFP flag does not.
Hugh
prev parent reply other threads:[~2003-04-17 22:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-17 20:46 [PATCH] stop swapoff 1/3 vm_enough_memory? Hugh Dickins
2003-04-17 20:47 ` [PATCH] stop swapoff 2/3 EINTR Hugh Dickins
2003-04-17 20:49 ` [PATCH] stop swapoff 3/3 OOMkill Hugh Dickins
2003-04-17 21:55 ` Andrew Morton
2003-04-17 23:10 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0304172359320.1178-100000@localhost.localdomain \
--to=hugh@veritas.com \
--cc=akpm@digeo.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).