* compile fix for IBM PCI hotplug driver (linux 2.4.21rc1-ac4)
@ 2003-05-04 14:01 Geller Sandor
0 siblings, 0 replies; 3+ messages in thread
From: Geller Sandor @ 2003-05-04 14:01 UTC (permalink / raw)
To: linux-kernel; +Cc: alan
A small fix for the IBM PCI hotplug driver.
--- ibmphp_ebda.c.orig Sun May 4 15:35:42 2003
+++ ibmphp_ebda.c Sun May 4 15:54:04 2003
@@ -754,7 +754,7 @@
struct ebda_hpc_slot *slot_ptr;
struct bus_info *bus_info_ptr1, *bus_info_ptr2;
int rc;
- struct slot *tmp_slot;
+ struct slot *slot_cur, *tmp_slot;
struct list_head *list;
char buf[32];
@@ -992,7 +992,7 @@
slot_cur = list_entry (list, struct slot, ibm_slot_list);
if(create_file_name (slot_cur, buf)==0)
{
- snprintf (slot_cur->hotplug_slot->name, 30, "%s", );
+ snprintf (slot_cur->hotplug_slot->name, 30, "%s" );
pci_hp_register (slot_cur->hotplug_slot);
}
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: compile fix for IBM PCI hotplug driver (linux 2.4.21rc1-ac4)
2003-05-04 14:39 Chuck Ebbert
@ 2003-05-04 18:36 ` Geller Sandor
0 siblings, 0 replies; 3+ messages in thread
From: Geller Sandor @ 2003-05-04 18:36 UTC (permalink / raw)
To: Chuck Ebbert; +Cc: linux-kernel
On Sun, 4 May 2003, Chuck Ebbert wrote:
>
> > if(create_file_name (slot_cur, buf)==0)
>
> Wow. Three whitespace violations on one line:
>
> - no space after 'if'
> - space between function and args
> - no space around '==' operator
>
> I know you didn't write that, I just had to comment because it almost
> hurts to look at it...
>
> >- snprintf (slot_cur->hotplug_slot->name, 30, "%s", );
> >+ snprintf (slot_cur->hotplug_slot->name, 30, "%s" );
>
>
> Doesn't this need a fourth parameter here instead of just
> removing the comma?
Yes, Andreas Haumer fixed the compile problems correctly in his post.
Geller Sandor <wildy@petra.hos.u-szeged.hu>
^ permalink raw reply [flat|nested] 3+ messages in thread
* compile fix for IBM PCI hotplug driver (linux 2.4.21rc1-ac4)
@ 2003-05-04 14:39 Chuck Ebbert
2003-05-04 18:36 ` Geller Sandor
0 siblings, 1 reply; 3+ messages in thread
From: Chuck Ebbert @ 2003-05-04 14:39 UTC (permalink / raw)
To: Geller Sandor; +Cc: linux-kernel
> if(create_file_name (slot_cur, buf)==0)
Wow. Three whitespace violations on one line:
- no space after 'if'
- space between function and args
- no space around '==' operator
I know you didn't write that, I just had to comment because it almost
hurts to look at it...
>- snprintf (slot_cur->hotplug_slot->name, 30, "%s", );
>+ snprintf (slot_cur->hotplug_slot->name, 30, "%s" );
Doesn't this need a fourth parameter here instead of just
removing the comma?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-05-04 18:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-04 14:01 compile fix for IBM PCI hotplug driver (linux 2.4.21rc1-ac4) Geller Sandor
2003-05-04 14:39 Chuck Ebbert
2003-05-04 18:36 ` Geller Sandor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).