From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261743AbTEHQPX (ORCPT ); Thu, 8 May 2003 12:15:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261564AbTEHQPX (ORCPT ); Thu, 8 May 2003 12:15:23 -0400 Received: from neon-gw-l3.transmeta.com ([63.209.4.196]:22788 "EHLO neon-gw.transmeta.com") by vger.kernel.org with ESMTP id S261743AbTEHQPW (ORCPT ); Thu, 8 May 2003 12:15:22 -0400 Date: Thu, 8 May 2003 09:27:19 -0700 (PDT) From: Linus Torvalds To: Jens Axboe cc: Bartlomiej Zolnierkiewicz , Alan Cox , Linux Kernel Mailing List Subject: Re: [PATCH] 2.5 ide 48-bit usage In-Reply-To: <20030508161600.GE20941@suse.de> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 8 May 2003, Jens Axboe wrote: > > Maybe a define or two would help here. When you see drive->addressing > and hwif->addressing, you assume that they are used identically. That > !hwif->addressing means 48-bit is ok, while !drive->addressing means > it's not does not help at all. Why not just change the names? The current setup clearly is confusing, and adding defines doesn't much help. Rename the structure member so that the name says what it is, aka "address_mode", and when renaming it you'd go through the source anyway and change "!addressing" to something more readable like "address_mode == IDE_LBA48" or whatever. (Anyway, I'll just drop all the 48-bit patches for now, since you've totally confused me about which ones are right and what the bugs are ;) Linus