linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pascal Schmidt <der.eremit@email.de>
To: Jens Axboe <axboe@suse.de>
Cc: Pascal Schmidt <der.eremit@email.de>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [IDE] trying to make MO drive work with ide-floppy/ide-cd
Date: Thu, 8 May 2003 13:33:18 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.44.0305081331570.1155-100000@neptune.local> (raw)
In-Reply-To: <20030507193347.GU823@suse.de>

On Wed, 7 May 2003, Jens Axboe wrote:

> Definitely, this looks like a fine start. As far as I'm concerned, it
> would be fine to commit to 2.5.

As maintainer of ide-cd, would you forward it to Linus, then?
CCed Alan for the ide-probe.c change.

Index: drivers/ide/ide-cd.c
===================================================================
RCS file: /home/bkcvs/linux-2.5/drivers/ide/ide-cd.c,v
retrieving revision 1.107
diff -u -1 -b -p -r1.107 ide-cd.c
--- drivers/ide/ide-cd.c	20 Apr 2003 21:52:14 -0000	1.107
+++ drivers/ide/ide-cd.c	7 May 2003 17:34:30 -0000
@@ -2873,2 +2873,7 @@ int ide_cdrom_probe_capabilities (ide_dr
 
+	if (drive->media == ide_optical) {
+		printk("%s: ATAPI magneto-optical drive\n", drive->name);
+		return nslots;
+	}
+
 	if (CDROM_CONFIG_FLAGS(drive)->nec260) {
@@ -3339,3 +3344,3 @@ static int ide_cdrom_attach (ide_drive_t
 		goto failed;
-	if (drive->media != ide_cdrom)
+	if (drive->media != ide_cdrom && drive->media != ide_optical)
 		goto failed;
Index: drivers/ide/ide-probe.c
===================================================================
RCS file: /home/bkcvs/linux-2.5/drivers/ide/ide-probe.c,v
retrieving revision 1.85
diff -u -1 -b -p -r1.85 ide-probe.c
--- drivers/ide/ide-probe.c	24 Apr 2003 17:07:04 -0000	1.85
+++ drivers/ide/ide-probe.c	7 May 2003 17:25:37 -0000
@@ -1237,3 +1237,3 @@ struct gendisk *ata_probe(dev_t dev, int
 			(void) request_module("ide-scsi");
-		if (drive->media == ide_cdrom)
+		if (drive->media == ide_cdrom || drive->media == ide_optical)
 			(void) request_module("ide-cd");

-- 
Ciao,
Pascal


  reply	other threads:[~2003-05-08 11:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-05 20:04 [IDE] trying to make MO drive work with ide-floppy Pascal Schmidt
2003-05-06  9:41 ` Alan Cox
2003-05-06 14:02   ` [IDE] trying to make MO drive work with ide-floppy/ide-cd Pascal Schmidt
2003-05-06 14:07     ` Jens Axboe
2003-05-06 15:19       ` Pascal Schmidt
2003-05-06 15:25         ` Jens Axboe
2003-05-06 15:43           ` Jens Axboe
2003-05-06 16:23             ` Pascal Schmidt
2003-05-06 16:22           ` Pascal Schmidt
2003-05-06 17:59           ` Pascal Schmidt
2003-05-06 18:04             ` Jens Axboe
2003-05-06 18:18               ` Pascal Schmidt
2003-05-06 14:10     ` Pascal Schmidt
2003-05-06 14:11       ` Jens Axboe
2003-05-06 15:15         ` Pascal Schmidt
2003-05-07 18:02       ` Pascal Schmidt
2003-05-07 19:33         ` Jens Axboe
2003-05-08 11:33           ` Pascal Schmidt [this message]
2003-05-08 12:09             ` Jens Axboe
2003-05-08 12:20               ` Bartlomiej Zolnierkiewicz
2003-05-08 12:43                 ` Pascal Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0305081331570.1155-100000@neptune.local \
    --to=der.eremit@email.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).