From: Linus Torvalds <torvalds@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Subject: Re: Fix IDE initialization when we don't probe for interrupts.
Date: Wed, 9 Jul 2003 15:25:59 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.44.0307091520570.16947-100000@home.osdl.org> (raw)
In-Reply-To: <3F0C9251.2010107@pobox.com>
On Wed, 9 Jul 2003, Jeff Garzik wrote:
>
> I'm curious where interrupts are re-enabled, though?
The low-level drivers seem to do it at every IO. Don't ask me why. But it
gets done automatically by any code that does
hwif->OUTB(drive->ctl, IDE_CONTROL_REG);
which is pretty common (just grep for "IDE_CONTROL_REG" and you'll see
what I mean).
I note that I should have made this "disable irq" be dependent on
IDE_CONTROL_REG being non-zero. Although I don't see when that register
_can_ be zero, it would be a major bummer not to have access to the
control register.
(Obviously it must be zero for some architecture, though, or those
conditionals woulnd't make sense. Alan? Bartlomiej? What kind of sick
pseudo-IDE controller doesn't have a control register?).
Linus
next prev parent reply other threads:[~2003-07-09 22:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200307092110.h69LAlgG027527@hera.kernel.org>
2003-07-09 22:08 ` Fix IDE initialization when we don't probe for interrupts Jeff Garzik
2003-07-09 22:25 ` Linus Torvalds [this message]
2003-07-09 22:51 ` Bartlomiej Zolnierkiewicz
2003-07-09 22:52 ` Jeff Garzik
2003-07-17 15:36 ` Geert Uytterhoeven
2003-07-09 23:28 ` Alan Cox
2003-07-17 15:32 ` Geert Uytterhoeven
2003-07-17 15:58 John Bradford
2003-07-17 15:52 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0307091520570.16947-100000@home.osdl.org \
--to=torvalds@osdl.org \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).