From: Patrick Mochel <mochel@osdl.org>
To: Pavel Machek <pavel@ucw.cz>
Cc: Linus Torvalds <torvalds@osdl.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: swsusp updates
Date: Sat, 26 Jul 2003 14:31:57 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.44.0307261422080.23977-100000@cherise> (raw)
In-Reply-To: <20030726211310.GG266@elf.ucw.cz>
> Okay, I killed few trivial hunks, will submit them through trivial
> patch monkey. Are you happy now, patrick?
Why do you insist on abusing the trivial patch monkey? Why can't you send
them directly to the maintainers? For instance, you add/remove printk()s
and comments that other people may or may not want in there.
But no, this doesn't make me happy because you insist on munging multiple
patches together that have little to do with each other, besides the fact
they touch the same file. Like I said in private email, it really helps to
track down a problem if each patch and subsequent changeset is as small
and localized as possible.
And, that's a real problem with swsusp. It's a huge mess right now. I'd
like to see it work well and reliably for 2.6, and have the source code be
in a state where people can look at it without running away screaming.
Convoluted updates are not going to help the situation.
-pat
next prev parent reply other threads:[~2003-07-26 21:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-26 20:45 swsusp updates Pavel Machek
2003-07-26 21:05 ` Patrick Mochel
2003-07-26 21:03 ` Pavel Machek
2003-07-26 21:09 ` Patrick Mochel
2003-07-26 21:13 ` Pavel Machek
2003-07-26 21:31 ` Patrick Mochel [this message]
2003-07-26 21:35 ` Pavel Machek
2003-07-26 21:37 ` Pavel Machek
2003-07-26 22:32 ` "linux-power" tree [was Re: swsusp updates] Pavel Machek
-- strict thread matches above, loose matches on Subject: below --
2003-08-04 20:14 swsusp updates Pavel Machek
2003-08-04 20:43 ` Andrew Morton
2003-08-04 22:13 ` Pavel Machek
2003-08-04 22:27 ` Andrew Morton
2002-10-29 23:15 Pavel Machek
2002-09-21 21:12 Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0307261422080.23977-100000@cherise \
--to=mochel@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).