linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, <torvalds@osdl.org>,
	Andi Kleen <ak@suse.de>
Subject: Re: PATCH: console on by default if not embedded (save mucho pain)
Date: Mon, 28 Jul 2003 11:02:26 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.44.0307281056400.717-100000@serv> (raw)
In-Reply-To: <200307272002.h6RK215U029586@hraefn.swansea.linux.org.uk>

Hi,

On Sun, 27 Jul 2003, Alan Cox wrote:

> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux-2.6.0-test2/drivers/char/Kconfig linux-2.6.0-test2-ac1/drivers/char/Kconfig
> --- linux-2.6.0-test2/drivers/char/Kconfig	2003-07-10 21:04:38.000000000 +0100
> +++ linux-2.6.0-test2-ac1/drivers/char/Kconfig	2003-07-16 18:39:32.000000000 +0100
> @@ -5,8 +5,9 @@
>  menu "Character devices"
>  
>  config VT
> -	bool "Virtual terminal"
> +	bool "Virtual terminal" if EMBEDDED
>  	requires INPUT=y
> +	default y
>  	---help---
>  	  If you say Y here, you will get support for terminal devices with
>  	  display and keyboard devices. These are called "virtual" because you

The patch below is better and this is one actually fixes most of the 
upgrade pain, as the other options have reasonable defaults.
I'm not sure we should hide that much behind EMBEDDED, for people who just 
want to load an old config and expect something workable the patch below 
is enough, other people have to search for all the options hidden behind 
EMBEDDED.

bye, Roman

Index: drivers/char/Kconfig
===================================================================
RCS file: /home/other/cvs/linux/linux-2.6/drivers/char/Kconfig,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Kconfig
--- drivers/char/Kconfig	14 Jul 2003 09:22:00 -0000	1.1.1.1
+++ drivers/char/Kconfig	22 Jul 2003 08:08:26 -0000
@@ -6,7 +6,7 @@ menu "Character devices"
 
 config VT
 	bool "Virtual terminal"
-	requires INPUT=y
+	select INPUT
 	---help---
 	  If you say Y here, you will get support for terminal devices with
 	  display and keyboard devices. These are called "virtual" because you


      parent reply	other threads:[~2003-07-28  8:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-27 20:02 Alan Cox
2003-07-28  7:12 ` Christoph Hellwig
2003-07-28  9:02 ` Roman Zippel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0307281056400.717-100000@serv \
    --to=zippel@linux-m68k.org \
    --cc=ak@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --subject='Re: PATCH: console on by default if not embedded (save mucho pain)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).