From: Roman Zippel <zippel@linux-m68k.org>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Greg KH <greg@kroah.com>, <linux-usb-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] reorganize USB submenu's
Date: Thu, 31 Jul 2003 19:45:29 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.44.0307311940270.717-100000@serv> (raw)
In-Reply-To: <20030731101144.32a3f0d7.shemminger@osdl.org>
On Thu, 31 Jul 2003, Stephen Hemminger wrote:
> diff -Nru a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> --- a/drivers/usb/gadget/Kconfig Thu Jul 31 10:07:11 2003
> +++ b/drivers/usb/gadget/Kconfig Thu Jul 31 10:07:11 2003
> @@ -6,9 +6,12 @@
> # for 2.5 kbuild, drivers/usb/gadget/Kconfig
> # source this at the end of drivers/usb/Kconfig
> #
> -menuconfig USB_GADGET
> +menu "USB Gadgets"
> + depends on USB!=n
> +
> +config USB_GADGET
> tristate "Support for USB Gadgets"
> - depends on EXPERIMENTAL
> + depends on USB && EXPERIMENTAL
> help
> USB is a master/slave protocol, organized with one master
> host (such as a PC) controlling up to 127 peripheral devices.
Why do you remove the menuconfig?
USB_GADGET is independent of USB.
> diff -Nru a/drivers/usb/input/Kconfig b/drivers/usb/input/Kconfig
> --- a/drivers/usb/input/Kconfig Thu Jul 31 10:07:11 2003
> +++ b/drivers/usb/input/Kconfig Thu Jul 31 10:07:11 2003
> @@ -1,8 +1,10 @@
> #
> # USB Input driver configuration
> #
> -comment "USB Human Interface Devices (HID)"
> - depends on USB
> +menu "USB Input devices"
> +
> +comment "Input core support is needed for USB HID input layer or HIDBP support"
> + depends on USB && INPUT=n
>
> config USB_HID
> tristate "USB Human Interface Device (full HID) support"
The menu needs to depend on USB otherwise you'll have empty menus if USB
is disabled (the same is true for storage/media/net).
bye, Roman
next prev parent reply other threads:[~2003-07-31 17:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-31 17:11 [PATCH] reorganize USB submenu's Stephen Hemminger
2003-07-31 17:45 ` Roman Zippel [this message]
2003-07-31 17:51 ` Greg KH
[not found] ` <23979.216.12.38.216.1059672599.squirrel@www.ghz.cc>
2003-07-31 19:50 ` Stephen Hemminger
2003-07-31 20:16 ` Greg KH
2003-07-31 21:14 ` Stephen Hemminger
2003-07-31 22:57 ` Stephen Hemminger
2003-07-31 21:07 ` [linux-usb-devel] " David Brownell
2003-07-31 21:18 ` Stephen Hemminger
2003-07-31 22:00 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0307311940270.717-100000@serv \
--to=zippel@linux-m68k.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).