From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S272219AbTHRSVP (ORCPT ); Mon, 18 Aug 2003 14:21:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S272223AbTHRSVO (ORCPT ); Mon, 18 Aug 2003 14:21:14 -0400 Received: from fw.osdl.org ([65.172.181.6]:1472 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S272219AbTHRSVO (ORCPT ); Mon, 18 Aug 2003 14:21:14 -0400 Date: Mon, 18 Aug 2003 11:21:07 -0700 (PDT) From: Linus Torvalds To: Jeff Garzik cc: Linux Kernel Mailing List Subject: Re: Fix up riscom8 driver to use work queues instead of task queueing. In-Reply-To: <20030818180941.GJ24693@gtf.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Aug 2003, Jeff Garzik wrote: > > Should we just make schedule_delayed_work(foo, 1) the default for a > schedule_work() call? Why? There are cases where you may really want to get the work done asap, so the regular "schedule_work()" is the right thing. While the "delayed" thing is for stuff that explicitly doesn't want to happen immediately, because we expect to aggregate more into it. Having done a few serial drivers (not because I want to, but because nobody else seems to be doing them), I definitely see the need for both. For example, the hangup case wants to be done asap, not delayed. Linus