archive mirror
 help / color / mirror / Atom feed
From: Roman Zippel <>
To: Geert Uytterhoeven <>
Cc: Marcelo Tosatti <>,
	Linux Kernel Development <>
Subject: Re: [PATCH] M68k cache
Date: Fri, 29 Aug 2003 19:36:03 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.44.0308291743280.8124-100000@serv> (raw)
In-Reply-To: <200308291451.h7TEpE8k005932@callisto.of.borg>


On Fri, 29 Aug 2003, Geert Uytterhoeven wrote:

> M68k icache flush fixes from Roman Zippel:
>   - uninline flush_icache_range() and rename it to flush_icache_user_range()
>   - add virt_to_phys_slow() which handles vmalloc()ed space
>   - add flush_icache_range and flush_icache_user_page
> [...]
> --- linux-2.4.23-pre1/kernel/ptrace.c	Wed May 28 13:11:52 2003
> +++ linux-m68k-2.4.23-pre1/kernel/ptrace.c	Fri Jul 25 20:02:39 2003
> @@ -165,7 +165,7 @@
>  		if (write) {
>  			memcpy(maddr + offset, buf, bytes);
>  			flush_page_to_ram(page);
> -			flush_icache_user_range(vma, page, addr, len);
> +			flush_icache_user_page(vma, page, addr, len);
>  			set_page_dirty(page);
>  		} else {
>  			memcpy(buf, maddr + offset, bytes);

Geert, did you intend to include this part?
This part needs an update of all archs includes (to define 
flush_icache_user_page at least as flush_icache_user_range) and the 
changes to binfmt_{elf,aout}.c are part of this patch.
Maybe I should explain the reason behind this patch:
The actual problem is the usage of flush_icache_range(). In 
kernel/module.c it's used to flush data from the kernel cache, in 
binfmt_{elf,aout}.c it's used to flush data from the user cache and in 
both situations it's called with a user space context, so that 
flush_icache_range() doesn't know which cache to flush and I'd really 
like to avoid having to flush both caches.
So the full patch renames flush_icache_range() in binfmt_{elf,aout}.c into 
flush_icache_user_range(), but which already exists, so I renamed this 
into flush_icache_user_page().

bye, Roman

  reply	other threads:[~2003-08-29 17:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-29 14:51 [PATCH] M68k cache Geert Uytterhoeven
2003-08-29 17:36 ` Roman Zippel [this message]
2003-08-29 18:05   ` Geert Uytterhoeven
  -- strict thread matches above, loose matches on Subject: below --
2003-07-26 14:51 [PATCH] m68k cache Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0308291743280.8124-100000@serv \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).