From: Linus Torvalds <torvalds@osdl.org>
To: viro@parcelfarce.linux.theplanet.co.uk
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
lkml <linux-kernel@vger.kernel.org>, <olof@austin.ibm.com>
Subject: Re: [PATCH] [2.4] Re: /proc/ioports overrun patch
Date: Wed, 24 Sep 2003 15:54:10 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.44.0309241547360.9506-100000@home.osdl.org> (raw)
In-Reply-To: <20030924223657.GB7665@parcelfarce.linux.theplanet.co.uk>
On Wed, 24 Sep 2003 viro@parcelfarce.linux.theplanet.co.uk wrote:
>
> Umm... Linus, output truncation is 2.4 problem; any seq_file-based
> variant (including one already in 2.6 and being backported to 2.4) solves
> that. The thing being, variant we had in 2.6 was ugly - it had walk through
> the tree shoved into ->show() instead of having the iterator do that for
> us.
Yeah, my bad for trying to clean up comments. I just looked at the
seq_printf() usage without error checking, without thinking about the loop
and checking in the outer layer (ie the seq_read() loop).
Me bad.
You can't undo something in BK (once it is out), but feel free to send me
a patch that adds the appropriate comments, and calls me a pinhead for the
changelog ;)
Linus
prev parent reply other threads:[~2003-09-24 22:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-29 13:30 /proc/ioports overrun patch Marcelo Tosatti
2003-08-29 18:59 ` john stultz
2003-09-24 19:42 ` [PATCH] [2.4] " olof
2003-09-24 19:51 ` viro
2003-09-24 19:59 ` viro
2003-09-24 21:47 ` viro
2003-09-24 22:36 ` viro
2003-09-24 22:54 ` Linus Torvalds [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0309241547360.9506-100000@home.osdl.org \
--to=torvalds@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=olof@austin.ibm.com \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).