From: Linus Torvalds <torvalds@osdl.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Tim Hockin <thockin@hockin.org>, <linux-kernel@vger.kernel.org>,
<torvalds@transmeta.com>, <braam@clusterfs.com>,
<neilb@cse.unsw.edu.au>
Subject: Re: [PATCH] Many groups patch.
Date: Mon, 29 Sep 2003 10:25:31 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.44.0309291024040.28114-100000@home.osdl.org> (raw)
In-Reply-To: <20030929072027.903AC2C07F@lists.samba.org>
On Mon, 29 Sep 2003, Rusty Russell wrote:
>
> This version drops the internal groups array (it's so often shared
> that it's not worth it, and the logic becomes a bit neater), and does
> vmalloc fallback in case someone has massive number of groups.
Why?
kmalloc() works fine. Anybody who needs 200 groups may be sane, but
anybody who needs more than fits in a kmalloc() is definitely so far out
that there is no point.
The vmalloc space is limited, and the code just gets uglier.
Have you been looking at glibc sources lately, or why do you believe that
we should encourage insane usage?
Linus
next prev parent reply other threads:[~2003-09-29 17:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-29 7:19 [PATCH] Many groups patch Rusty Russell
2003-09-29 17:25 ` Linus Torvalds [this message]
2003-09-29 23:30 ` Rusty Russell
2003-09-30 4:11 ` Tim Hockin
2003-10-01 7:29 ` Rusty Russell
[not found] <mailman.1064857032.26219.linux-kernel2news@redhat.com>
2003-09-29 22:29 ` Pete Zaitcev
2003-09-29 22:43 ` Tim Hockin
2003-09-29 22:55 ` Tim Hockin
2003-09-29 23:10 ` Linus Torvalds
2003-10-01 7:10 ` Tim Hockin
2003-10-01 18:46 ` Tim Hockin
2003-10-01 19:22 ` Linus Torvalds
2003-10-01 20:29 ` Tim Hockin
2003-10-01 20:46 ` Linus Torvalds
2003-10-01 21:12 ` Tim Hockin
2003-10-01 21:16 ` Tim Hockin
2003-10-02 2:09 ` Rusty Russell
2003-10-02 4:39 ` Tim Hockin
2003-10-02 9:10 ` David S. Miller
2003-10-02 2:25 ` Rusty Russell
2003-10-02 2:46 ` Pete Zaitcev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0309291024040.28114-100000@home.osdl.org \
--to=torvalds@osdl.org \
--cc=braam@clusterfs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=rusty@rustcorp.com.au \
--cc=thockin@hockin.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).