From: Linus Torvalds <torvalds@osdl.org>
To: Zwane Mwaikambo <zwane@arm.linux.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>,
"Martin J. Bligh" <mbligh@aracnet.com>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
Hugh Dickins <hugh@veritas.com>
Subject: Re: [PATCH][2.6-mm] Fix 4G/4G X11/vm86 oops
Date: Tue, 18 Nov 2003 08:37:25 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.44.0311180830050.18739-100000@home.osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.53.0311181113150.11537@montezuma.fsmlabs.com>
On Tue, 18 Nov 2003, Zwane Mwaikambo wrote:
>
> Here are diffs from the do_sys_vm86 only.
Ok. Much more readable.
And there is something very suspicious there.
The code with and without the printk() looks _identical_ apart from some
trivial label renumbering, and the added
pushl $.LC6
call printk
.. asm ..
popl %esi
which all looks fine (esi is dead at that point, so the compiler is just
using a "popl" as a shorter form of "addl $4,%esp").
Btw, you seem to compile with debugging, which makes the assembly
language pretty much unreadable and accounts for most of the
differences: the line numbers change. If you compile a kernel where the
line numbers don't change (by commenting _out_ the printk rather than
removing the whole line), your diff would be more readable.
Anyway, there are _zero_ differences.
Just for fun, try this: move the "printk()" to _below_ the "asm"
statement. It will never actually get executed, but if it's an issue of
some subtle code or data placement things (cache lines etc), maybe that
also hides the oops, since all the same code and data will be generated,
just not run...
Linus
next prev parent reply other threads:[~2003-11-18 16:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-13 7:30 2.6.0-test9-mm3 Andrew Morton
2003-11-13 20:03 ` [PATCH] linux-2.6.0-test9-mm3_verbose-timesource-acpi-pm_A0 john stultz
2003-11-13 22:03 ` 2.6.0-test9-mm3 - AIO test results Daniel McNeil
2003-11-17 5:25 ` Suparna Bhattacharya
2003-11-18 1:15 ` Daniel McNeil
2003-11-18 1:37 ` Daniel McNeil
2003-11-18 11:55 ` Suparna Bhattacharya
2003-11-18 23:47 ` Daniel McNeil
2003-11-24 9:42 ` Suparna Bhattacharya
2003-11-25 23:49 ` [PATCH 2.6.0-test9-mm5] aio-dio-fallback-bio_count-race.patch Daniel McNeil
2003-11-26 7:55 ` Suparna Bhattacharya
2003-12-02 1:35 ` Daniel McNeil
2003-12-02 15:25 ` Suparna Bhattacharya
2003-12-03 23:14 ` Daniel McNeil
2003-12-04 4:40 ` Suparna Bhattacharya
2003-11-13 22:04 ` 2.6.0-test9-mm3 (compile stats) John Cherry
2003-11-14 5:07 ` 2.6.0-test9-mm3 Martin J. Bligh
2003-11-14 20:57 ` 2.6.0-test9-mm3 Zwane Mwaikambo
2003-11-14 21:57 ` 2.6.0-test9-mm3 Martin J. Bligh
2003-11-14 21:37 ` 2.6.0-test9-mm3 Zwane Mwaikambo
2003-11-14 21:47 ` 2.6.0-test9-mm3 Linus Torvalds
2003-11-15 0:55 ` 2.6.0-test9-mm3 Zwane Mwaikambo
2003-11-15 19:34 ` [PATCH][2.6-mm] Fix 4G/4G X11/vm86 oops Zwane Mwaikambo
2003-11-15 19:52 ` Zwane Mwaikambo
2003-11-17 21:46 ` Zwane Mwaikambo
2003-11-17 22:42 ` Linus Torvalds
2003-11-17 23:01 ` Zwane Mwaikambo
2003-11-17 23:14 ` Zwane Mwaikambo
2003-11-18 7:21 ` Zwane Mwaikambo
2003-11-18 15:47 ` Linus Torvalds
2003-11-18 16:16 ` Zwane Mwaikambo
2003-11-18 16:37 ` Linus Torvalds [this message]
2003-11-18 17:08 ` Zwane Mwaikambo
2003-11-18 17:38 ` Martin J. Bligh
2003-11-18 17:22 ` Zwane Mwaikambo
2003-11-19 20:32 ` Matt Mackall
2003-11-19 23:09 ` Matt Mackall
2003-11-20 7:14 ` Zwane Mwaikambo
2003-11-20 7:44 ` Matt Mackall
2003-11-20 7:53 ` Andrew Morton
2003-11-20 8:13 ` Matt Mackall
2003-11-14 19:08 ` 2.6.0-test9-mm3 Martin J. Bligh
2003-11-14 18:59 ` 2.6.0-test9-mm3 Andrew Morton
2003-11-14 19:32 ` 2.6.0-test9-mm3 Mike Fedyk
2003-11-14 20:27 ` 2.6.0-test9-mm3 John Stoffel
2003-11-15 1:01 ` 2.6.0-test9-mm3 Mike Fedyk
2003-11-14 19:10 ` 2.6.0-test9-mm3 Badari Pulavarty
2003-11-14 20:29 ` 2.6.0-test9-mm3 Martin J. Bligh
2003-11-17 20:58 ` 2.6.0-test9-mm3 bill davidsen
2003-11-18 23:48 Re:Re: [PATCH][2.6-mm] Fix 4G/4G X11/vm86 oops Jon Foster
2003-11-19 3:24 ` Zwane Mwaikambo
2003-11-19 5:45 ` Andrew Morton
2003-11-19 6:50 ` Zwane Mwaikambo
2003-11-19 7:24 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0311180830050.18739-100000@home.osdl.org \
--to=torvalds@osdl.org \
--cc=akpm@osdl.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mbligh@aracnet.com \
--cc=mingo@elte.hu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).