From: Marcelo Tosatti <marcelo@conectiva.com.br>
To: Francois Romieu <romieu@cogenit.fr>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held
Date: Mon, 7 Oct 2002 16:13:58 -0300 (BRT) [thread overview]
Message-ID: <Pine.LNX.4.44L.0210071613320.21638-100000@freak.distro.conectiva> (raw)
In-Reply-To: <20021005225410.A22417@fafner.intra.cogenit.fr>
On Sat, 5 Oct 2002, Francois Romieu wrote:
> drivers/atm/iphase.c:tx_intr()
> [...]
> 1684 spin_lock_irqsave(&iadev->tx_lock, flags);
> 1685 ia_tx_poll(iadev);
>
> ia_tx_poll ->
> ia_hack_tcq ->
> ia_enque_rtn_q ->
> IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_KERNEL);
>
> Driver does not seem maintained. Please apply.
>
> --- linux-2.4.20-pre9.orig/drivers/atm/iphase.c Sat Oct 5 15:51:28 2002
> +++ linux-2.4.20-pre9/drivers/atm/iphase.c Sat Oct 5 22:44:18 2002
> @@ -124,7 +124,7 @@ static void ia_enque_head_rtn_q (IARTN_Q
> }
>
> static int ia_enque_rtn_q (IARTN_Q *que, struct desc_tbl_t data) {
> - IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_KERNEL);
> + IARTN_Q *entry = kmalloc(sizeof(*entry), GFP_ATOMIC);
> if (!entry) return -1;
> entry->data = data;
> entry->next = NULL;
It seems correct. Have you tried to send this to Peter Wang
<pwang@iphase.com> ?
next prev parent reply other threads:[~2002-10-07 19:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-05 20:54 [patch] 2.4.20-pre9 - drivers/atm/iphase.c : GFP_KERNEL with spinlock held Francois Romieu
2002-10-07 19:13 ` Marcelo Tosatti [this message]
2002-10-07 22:15 ` Francois Romieu
2002-10-08 8:46 ` Adrian Bunk
2002-10-08 11:01 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L.0210071613320.21638-100000@freak.distro.conectiva \
--to=marcelo@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@cogenit.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).