From: Alan Stern <stern@rowland.harvard.edu>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: Greg KH <greg@kroah.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
<linux-kernel@vger.kernel.org>,
Kay Sievers <kay.sievers@vrfy.org>,
Jonathan Corbet <corbet@lwn.net>,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: [RFC] Sample kset/ktype/kobject implementation
Date: Fri, 30 Nov 2007 09:51:27 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.44L0.0711300949070.3833-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <a8e1da0711292107q4e2e0282o2d37798dc529288c@mail.gmail.com>
On Fri, 30 Nov 2007, Dave Young wrote:
> > The rule is simple enough. After calling kobject_register() you should
> > always use kobject_put() -- even if kobject_register() failed.
> >
> > In fact, after calling kobject_init() you should use kobject_put().
> > The first rule follows from this one, since kobject_register() calls
> > kobject_init() internally.
> >
> Hi,
> The behavior is not very clear here, the root problem is that :
>
> 1. Should we call kobject_put so cleanup work can be done by refcount
> touch zero or call kfree every time after kobject_register failed?
Call kobject_put so that the cleanup work will be done when the
refcount goes to 0. Don't call kfree.
> 2. If kobject_put calling is true, should this be done in
> kobject_register error handling codes or by hand after
> kobject_register failed?
It should be done by hand after kobject_register fails. Otherwise
kobject_register would end up dropping a reference that it never
acquired.
Alan Stern
next prev parent reply other threads:[~2007-11-30 14:51 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-27 23:02 [RFC] New kobject/kset/ktype documentation and example code Greg KH
2007-11-27 23:03 ` [RFC] sample kobject implementation Greg KH
2007-11-27 23:04 ` [RFC] Sample kset/ktype/kobject implementation Greg KH
2007-11-28 16:35 ` Cornelia Huck
2007-11-29 6:11 ` Greg KH
2007-11-29 9:39 ` Cornelia Huck
2007-11-29 20:39 ` Greg KH
2007-11-29 22:11 ` Alan Stern
2007-11-30 5:07 ` Dave Young
2007-11-30 5:57 ` Dave Young
2007-11-30 14:51 ` Alan Stern [this message]
2007-11-30 6:41 ` Greg KH
2007-11-27 23:10 ` [RFC] New kobject/kset/ktype documentation and example code Kyle McMartin
2007-11-27 23:29 ` Greg KH
2007-11-27 23:21 ` Frans Pop
2007-11-28 3:50 ` Jonathan Corbet
2007-11-29 5:46 ` Greg KH
2007-11-28 9:01 ` Cornelia Huck
2007-11-28 12:35 ` Kay Sievers
2007-11-28 15:52 ` Cornelia Huck
2007-11-28 16:03 ` Kay Sievers
2007-11-28 16:09 ` Cornelia Huck
2007-11-28 17:06 ` Greg KH
2007-11-28 19:18 ` Alan Stern
2007-11-29 10:12 ` Cornelia Huck
2007-11-29 15:47 ` Alan Stern
2007-11-29 16:28 ` Cornelia Huck
2007-11-29 16:55 ` Alan Stern
2007-11-29 17:52 ` Cornelia Huck
2007-11-29 5:59 ` Greg KH
2007-11-28 11:45 ` Cornelia Huck
2007-11-28 12:23 ` Kay Sievers
2007-11-28 15:48 ` Cornelia Huck
2007-11-28 15:57 ` Kay Sievers
2007-11-28 16:12 ` Cornelia Huck
2007-11-28 16:36 ` Kay Sievers
2007-11-28 16:51 ` Cornelia Huck
2007-11-28 17:00 ` Kay Sievers
2007-11-29 6:08 ` Greg KH
2007-11-29 7:50 ` Kay Sievers
2007-11-29 9:35 ` Cornelia Huck
2007-11-29 10:53 ` Kay Sievers
2007-11-29 6:02 ` Greg KH
2007-11-29 6:04 ` Greg KH
2007-11-29 9:41 ` Cornelia Huck
2007-11-28 19:03 ` Alan Stern
2007-11-28 19:28 ` Kay Sievers
2007-11-28 19:36 ` Alan Stern
2007-11-28 19:46 ` Kay Sievers
2007-11-28 20:42 ` [PATCH] kobject: make sure kobj->ktype is set before kobject_init Alan Stern
2007-11-28 20:52 ` Kay Sievers
2007-11-28 21:45 ` Greg KH
2007-11-28 22:00 ` Alan Stern
2007-11-28 22:38 ` Greg KH
2007-11-29 10:05 ` Cornelia Huck
2007-11-29 10:59 ` Kay Sievers
2007-11-29 11:48 ` Cornelia Huck
2007-11-29 15:54 ` Alan Stern
2007-11-29 16:04 ` Kay Sievers
2007-11-29 16:21 ` Cornelia Huck
2007-11-29 21:53 ` kobject_init rewrite Greg KH
2007-11-29 21:54 ` Greg KH
2007-11-30 9:31 ` Cornelia Huck
2007-11-29 22:16 ` Alan Stern
2007-11-29 22:24 ` Greg KH
2007-11-29 17:06 ` [PATCH] kobject: make sure kobj->ktype is set before kobject_init Alan Stern
2007-11-29 17:17 ` Kay Sievers
2007-11-29 18:04 ` Alan Stern
2007-11-29 18:33 ` Kay Sievers
2007-11-29 19:05 ` Alan Stern
2007-11-29 19:51 ` Kay Sievers
2007-11-29 20:09 ` Alan Stern
2007-11-29 20:19 ` Kay Sievers
2007-11-29 20:26 ` Kay Sievers
2007-11-30 9:30 ` Cornelia Huck
2007-11-29 6:18 ` [RFC] New kobject/kset/ktype documentation and example code Greg KH
2007-11-29 15:42 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.0711300949070.3833-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=corbet@lwn.net \
--cc=cornelia.huck@de.ibm.com \
--cc=greg@kroah.com \
--cc=hidave.darkstar@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).