From: Alan Stern <stern@rowland.harvard.edu>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] drivers/usb/host/ehci-platform.c: fix error return code
Date: Wed, 15 Aug 2012 10:37:15 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1208151036500.1674-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <1344926858-1162-6-git-send-email-Julia.Lawall@lip6.fr>
On Tue, 14 Aug 2012, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Convert a possibly 0 error return code to a negative one, as returned
> elsewhere in the function.
...
> diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c
> index 91acdde..764e010 100644
> --- a/drivers/usb/host/ehci-platform.c
> +++ b/drivers/usb/host/ehci-platform.c
> @@ -128,8 +128,10 @@ static int __devinit ehci_platform_probe(struct platform_device *dev)
> }
>
> hcd->regs = ioremap_nocache(hcd->rsrc_start, hcd->rsrc_len);
> - if (!hcd->regs)
> + if (!hcd->regs) {
> + err = -ENOMEM;
> goto err_release_region;
> + }
> err = usb_add_hcd(hcd, irq, IRQF_SHARED);
> if (err)
> goto err_iounmap;
Acked-by: Alan Stern <stern@rowland.harvard.edu>
prev parent reply other threads:[~2012-08-15 14:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 6:47 [PATCH 0/5] fix error return code Julia Lawall
2012-08-14 6:47 ` [PATCH 1/5] drivers/usb/gadget/s3c-hsotg.c: " Julia Lawall
2012-08-14 6:47 ` [PATCH 2/5] drivers/tty/moxa.c: " Julia Lawall
2012-08-14 6:47 ` [PATCH 3/5] drivers/usb/wusbcore/wa-hc.c: " Julia Lawall
2012-08-14 6:47 ` [PATCH 4/5] drivers/usb/host/ohci-platform.c: " Julia Lawall
2012-08-15 14:37 ` Alan Stern
2012-08-14 6:47 ` [PATCH 5/5] drivers/usb/host/ehci-platform.c: " Julia Lawall
2012-08-15 14:37 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1208151036500.1674-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=Julia.Lawall@lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).