From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932312Ab2IDOes (ORCPT ); Tue, 4 Sep 2012 10:34:48 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:56324 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S932285Ab2IDOeq (ORCPT ); Tue, 4 Sep 2012 10:34:46 -0400 Date: Tue, 4 Sep 2012 10:34:44 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Nicolas Ferre cc: gregkh@linuxfoundation.org, , , , , , Subject: Re: [PATCH] USB: ohci-at91: fix PIO handling in relation with number of ports In-Reply-To: <5045BB6A.8060309@atmel.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Sep 2012, Nicolas Ferre wrote: > On 08/29/2012 11:49 AM, Nicolas Ferre : > > If the number of ports present on the SoC/board is not the maximum > > and that the platform data is not filled with all data, there is > > an easy way to mess the PIO setup for this interface. > > This quick fix addresses mis-configuration in USB host platform data > > that is common in at91 boards since commit 0ee6d1e (USB: ohci-at91: > > change maximum number of ports) that did not modified the associatd > > board files. > > > > Reported-by: Klaus Falkner > > Signed-off-by: Nicolas Ferre > > Cc: Alan Stern > > Cc: Greg Kroah-Hartman > > Cc: linux-usb@vger.kernel.org > > Cc: Stable [3.4+] > > Alan, Greg, gentle ping... > > I really would like to seen it landing in stable soon... > > Thanks, best regards, Sorry for the delay. I feel a little uncomfortable judging board-level changes like this, since I know nothing about the hardware details. Still, for what it's worth, this patch is okay as far as the core ohci-hcd driver components are concerned. So... Acked-by: Alan Stern