From: Alan Stern <stern@rowland.harvard.edu>
To: Manjunath Goudar <manjunath.goudar@linaro.org>
Cc: linux-usb@vger.kernel.org, <linux-arm-kernel@lists.infradead.org>,
<patches@linaro.org>, <arnd@linaro.org>,
<linaro-kernel@lists.linaro.org>, Greg KH <greg@kroah.com>,
Wan ZongShun <mcuos.com@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] USB: EHCI: make ehci-w90X900 a separate driver
Date: Thu, 27 Jun 2013 14:09:27 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1306271405030.1167-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <1372347109-5563-1-git-send-email-manjunath.goudar@linaro.org>
On Thu, 27 Jun 2013, Manjunath Goudar wrote:
> Separate the W90X900(W90P910) on-chip host controller driver from
> ehci-hcd host code so that it can be built as a separate driver module.
> This work is part of enabling multi-platform kernels on ARM;
> however, note that other changes are still needed before W90X900(W90P910)
> can be booted with a multi-platform kernel
>
> and an ehci driver that only works on one of them.
>
> With the infrastructure added by Alan Stern in patch 3e0232039
> "USB: EHCI: prepare to make ehci-hcd a library module", we can
> avoid this problem by turning a bus glue into a separate
> module, as we do here for the w90X900 bus glue.
> diff --git a/drivers/usb/host/ehci-w90x900.c b/drivers/usb/host/ehci-w90x900.c
> index 59e0e24..d9ecd79 100644
> --- a/drivers/usb/host/ehci-w90x900.c
> +++ b/drivers/usb/host/ehci-w90x900.c
> @@ -11,13 +11,28 @@
> *
> */
>
> +#include <linux/io.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/usb.h>
> +#include <linux/usb/hcd.h>
> +#include <linux/dma-mapping.h>
> +#include <linux/of.h>
Alphabetical order, please.
> #include <linux/platform_device.h>
>
> +#include "ehci.h"
> +
> /* enable phy0 and phy1 for w90p910 */
> #define ENPHY (0x01<<8)
> #define PHY0_CTR (0xA4)
> #define PHY1_CTR (0xA8)
>
> +#define DRIVER_DESC "w90p910 usb ehci driver!"
I know this is what it said originally, but let's make it look more
like the other drivers. It doesn't need to say "usb", and it doesn't
need the '!' character at the end. Also, 'ehci' should be in capital
letters.
Finally, shouldn't it say "w90x900" instead of "w90p910"?
The rest of the patch is okay.
Alan Stern
next prev parent reply other threads:[~2013-06-27 18:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 15:31 [PATCH] USB: EHCI: make ehci-w90X900 a separate driver Manjunath Goudar
2013-06-27 18:09 ` Alan Stern [this message]
2013-07-22 10:19 ` [PATCH V2] " Manjunath Goudar
2013-07-23 2:05 ` Wan ZongShun
2013-07-23 18:53 ` Alan Stern
2013-07-31 10:05 ` Manjunath Goudar
2013-08-10 7:34 ` Manjunath Goudar
2013-08-12 20:17 ` Greg KH
2013-09-13 12:33 ` Manjunath Goudar
2013-09-21 11:14 ` Manjunath Goudar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1306271405030.1167-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=arnd@linaro.org \
--cc=greg@kroah.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=manjunath.goudar@linaro.org \
--cc=mcuos.com@gmail.com \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).