From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161007AbbENPvP (ORCPT ); Thu, 14 May 2015 11:51:15 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:58957 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S933736AbbENPvM (ORCPT ); Thu, 14 May 2015 11:51:12 -0400 Date: Thu, 14 May 2015 11:51:10 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Felipe Balbi cc: Tony Lindgren , "Rafael J. Wysocki" , Andreas Fenkart , Greg Kroah-Hartman , Huiquan Zhong , Kevin Hilman , NeilBrown , Mika Westerberg , Nishanth Menon , Peter Hurley , Sebastian Andrzej Siewior , Ulf Hansson , Thomas Gleixner , , , , Subject: Re: [PATCH 2/5] PM / Wakeirq: Add automated device wake IRQ handling In-Reply-To: <20150514020634.GB20006@saruman.tx.rr.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 13 May 2015, Felipe Balbi wrote: > This brings up a question, actually. What to do with devices which were > already runtime suspended when user initiated suspend-to-ram ? Do we > leave wakeups enabled, or do we revisit device_may_wakeup() and > conditionally runtime_resume the device, disable wakeup, and let its > ->suspend() callback be called ? In theory, the subsystem/device drivers already have code do this. They're supposed to, anyway. The USB host stack does it in drivers/usb/core/driver.c:choose_wakeup(). Alan Stern