From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752538AbcF1Pkc (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Jun 2016 11:40:32 -0400
Received: from iolanthe.rowland.org ([192.131.102.54]:38022 "HELO
	iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with SMTP id S1752188AbcF1Pka (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Jun 2016 11:40:30 -0400
Date: Tue, 28 Jun 2016 11:40:13 -0400 (EDT)
From: Alan Stern <stern@rowland.harvard.edu>
X-X-Sender: stern@iolanthe.rowland.org
To: Joseph Salisbury <joseph.salisbury@canonical.com>
cc: Greg KH <gregkh@linuxfoundation.org>, <rtatiya@codeaurora.org>,
        Robert Ancell <robert.ancell@canonical.com>,
        "mathias.nyman@linux.intel.com" <mathias.nyman@linux.intel.com>,
        <chasemetzger15@gmail.com>, <baolu.lu@linux.intel.com>,
        <oneukum@suse.com>, <kborer@gmail.com>, <jun.li@freescale.com>,
        USB list <linux-usb@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [v4.2-rc1 Regression] usb: Enable LPM for USB 2.01+ full-speed
 devices
In-Reply-To: <57729332.8040104@canonical.com>
Message-ID: <Pine.LNX.4.44L0.1606281138440.1697-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 28 Jun 2016, Joseph Salisbury wrote:

> On 06/24/2016 08:06 AM, Joseph Salisbury wrote:
> > On 06/22/2016 12:14 PM, Greg KH wrote:
> >> On Wed, Jun 22, 2016 at 11:38:43AM -0400, Joseph Salisbury wrote:
> >>> Hi Rupesh,
> >>>
> >>> A kernel bug report was opened against Ubuntu [0].  After a kernel
> >>> bisect, it was found that reverting the following commit resolved this bug:
> >>>
> >>> commit a8425292816ceaa8c49e29d2114e85d85a73e080
> >>> Author: Rupesh Tatiya <rtatiya@codeaurora.org>
> >>> Date:   Tue Apr 14 16:36:55 2015 +0530
> >>>
> >>>     usb: Enable LPM for USB 2.01+ full-speed devices
> >>>
> >>>
> >>> The regression was introduced as of v4.2-rc1.
> >>>
> >>> I was hoping to get your feedback, since you are the patch author.  Do
> >>> you think gathering any additional data will help diagnose this issue,
> >>> or would it be best to submit a revert request?
> >> Does the problem still happen with 4.7-rc4 or even 4.6?
> >>
> >> 4.2 is pretty old and obsolete you know :)
> >>
> >> thanks,
> >>
> >> greg k-h
> > The regression does exist in 4.6-rc2.  I'll have the latest mainline
> > 4.7-rc4 kernel tested.
> The 4.7-rc4 kernel still exhibits the bug.

Have you tried adding a NO_LPM quirk entry for this device, as I 
suggested in an earlier email?  I can write a patch for this, if you 
want.

Alan Stern