From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754176AbcHWPi1 (ORCPT ); Tue, 23 Aug 2016 11:38:27 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:59780 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1753883AbcHWPgq (ORCPT ); Tue, 23 Aug 2016 11:36:46 -0400 Date: Tue, 23 Aug 2016 11:30:04 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Wenyou Yang cc: Greg Kroah-Hartman , Nicolas Ferre , Alexandre Belloni , , , Subject: Re: [PATCH v7] usb: ohci-at91: Forcibly suspend ports while USB suspend In-Reply-To: <1471914329-14395-1-git-send-email-wenyou.yang@atmel.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Aug 2016, Wenyou Yang wrote: > The usb controller does not manage correctly the suspend mode for > the ehci. In echi mode, there is no way to suspend without any > device connected to it. This is why this specific control is added > to fix this issue. Since the suspend mode works in ohci mode, this > specific control works by suspend the usb controller in ohci mode. > > This specific control is by setting the SUSPEND_A/B/C fields of > SFR_OHCIICR(OHCI Interrupt Configuration Register) in the SFR > while the OHCI USB suspend. > > This set operation must be done before the USB clock disabled, > clear operation after the USB clock enabled. > > Signed-off-by: Wenyou Yang > Reviewed-by: Alexandre Belloni > Acked-by: Nicolas Ferre > --- > > Changes in v7: > - Rename ohci_at91_port_ctrl() to ohci_at91_port_suspend(). > - Add check valid_port(wIndex) before invoke > ohci_at91_port_suspend(). > - Call ohci_at91_port_suspend() directly on suspend/resume > operations. Acked-by: Alan Stern