From: Alan Stern <stern@rowland.harvard.edu>
To: Alexander Kappner <agk@godking.net>
Cc: Oliver Neukum <oneukum@suse.com>, <gregkh@linuxfoundation.org>,
<usb-storage@lists.one-eyed-alien.net>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] usb-storage: Add quirks to make G-Technology "G-Drive" work
Date: Thu, 17 May 2018 15:13:55 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1805171507420.1294-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <7dc7ea60-81b5-3546-5a12-9b0ff0b734cb@godking.net>
On Thu, 17 May 2018, Alexander Kappner wrote:
> Oliver and Alan,
>
> thank for investigating.
>
> > this is suspicious. You do not actually whether US_FL_NO_WP_DETECT
> > by itself would make the device work. Can you please test that?
>
> US_FL_NO_WP_DETECT without US_FL_IGNORE_UAS does not make a difference,
> even with the patch you included applied:
Are you certain Oliver's new code was executed? If you put
US_FL_NO_WP_DETECT only in unusual_devs.h and not in ususual_uas.h then
it would not affect the uas driver.
> > That's bizarre too. Even though the only difference is a MODE SENSE
> > command, the command that actually faliled was WRITE(16).
> It looks to me like the MODE SENSE simply hangs the drive, so anything
> issued after that will fail. Of course the drive says it's the "current
> command" that caused the failure, but I wouldn't give too much credence to
> that. FYI -- this device is a consumer grade rotational drive that you can
> get for less than $200, so I wouldn't be surprised if the implementations
> have issues.
>
> Also, I noticed that copying onto the drive with dd works fine, whereas
> trying to mount a filesystem immediately crashes it. I suspect this is
> because check_disk_change is called on mount (which eventually calls down
> to sd_read_write_protect_flag, which is where the US_FL_NO_WP_DETECT flag
> comes into play).
Was this tested with uas or usb-storage?
Alan Stern
next prev parent reply other threads:[~2018-05-17 19:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 20:01 [PATCH] usb-storage: Add quirks to make G-Technology "G-Drive" work Alexander Kappner
2018-05-16 20:55 ` Alan Stern
2018-05-17 8:15 ` Alexander Kappner
2018-05-17 12:58 ` Oliver Neukum
2018-05-17 18:38 ` Alexander Kappner
2018-05-17 19:13 ` Alan Stern [this message]
2018-05-18 17:51 ` Alexander Kappner
2018-05-18 20:35 ` Alan Stern
2018-05-19 4:50 ` [PATCH v2 0/2] " Alexander Kappner
2018-05-19 4:50 ` [PATCH v2 1/2] usb-storage: Add support for FL_ALWAYS_SYNC flag in the UAS driver Alexander Kappner
2018-05-22 8:58 ` [PATCH v2 1/2] [usb-storage] " Oliver Neukum
2018-05-19 4:50 ` [PATCH v2 2/2] usb-storage: Add compatibility quirk flags for G-Technologies G-Drive Alexander Kappner
2018-05-21 17:47 ` [PATCH v2 0/2] Re: usb-storage: Add quirks to make G-Technology "G-Drive" work Alan Stern
2018-05-22 8:57 ` [usb-storage] " Oliver Neukum
2018-05-17 14:44 ` [usb-storage] Re: [PATCH] " Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1805171507420.1294-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=agk@godking.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).