From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A999C5ACCC for ; Thu, 18 Oct 2018 14:35:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D099B20869 for ; Thu, 18 Oct 2018 14:35:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D099B20869 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728321AbeJRWhF (ORCPT ); Thu, 18 Oct 2018 18:37:05 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:46028 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1728245AbeJRWhF (ORCPT ); Thu, 18 Oct 2018 18:37:05 -0400 Received: (qmail 6108 invoked by uid 2102); 18 Oct 2018 10:35:47 -0400 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 18 Oct 2018 10:35:47 -0400 Date: Thu, 18 Oct 2018 10:35:47 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Al Cooper cc: linux-kernel@vger.kernel.org, Alban Bedel , Alex Elder , Andrew Morton , Arnd Bergmann , Avi Fishman , , Bjorn Andersson , Chunfeng Yun , "David S. Miller" , , Dmitry Osipenko , Greg Kroah-Hartman , "Gustavo A. R. Silva" , Hans de Goede , James Hogan , Jianguo Sun , Johan Hovold , Kees Cook , , Lu Baolu , Mark Rutland , Martin Blumenstingl , Mathias Nyman , Mathias Nyman , Mauro Carvalho Chehab , Rishabh Bhatnagar , Rob Herring , Roger Quadros Subject: Re: [PATCH V2 6/6] usb: host: Add ability to build new Broadcom STB USB drivers In-Reply-To: <1539815349-24126-7-git-send-email-alcooperx@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Oct 2018, Al Cooper wrote: > Add the build system changes needed to get the Broadcom STB XHCI, > EHCI and OHCI functionality working. The link order for XHCI was > changed in the Makefile because of the way STB XHCI, EHCI and OHCI > controllers share a port which requires that the XHCI driver be > initialized first. Also update MAINTAINERS. > > Signed-off-by: Al Cooper > --- > MAINTAINERS | 9 +++++++++ > drivers/usb/host/Kconfig | 29 +++++++++++++++++++++++++++++ > drivers/usb/host/Makefile | 18 ++++++++++++------ > 3 files changed, 50 insertions(+), 6 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 6ac000cc006d..7e062dcbe173 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3006,6 +3006,15 @@ S: Supported > F: drivers/gpio/gpio-brcmstb.c > F: Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt > > +BROADCOM BRCMSTB USB XHCI, EHCI and OHCI DRIVERS This should say "XHCI and EHCI". There is no Broadcom OHCI driver any more. > +M: Al Cooper > +L: linux-usb@vger.kernel.org > +L: bcm-kernel-feedback-list@broadcom.com > +S: Maintained > +F: drivers/usb/host/xhci-brcm.* > +F: drivers/usb/host/ohci-brcm.c This should say "ehci-brcm.c". > +F: Documentation/devicetree/bindings/usb/brcm,bcm7445-*.txt > + > BROADCOM BRCMSTB USB2 and USB3 PHY DRIVER > M: Al Cooper > L: linux-kernel@vger.kernel.org > diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig > index 1a4ea98cac2a..112de3334389 100644 > --- a/drivers/usb/host/Kconfig > +++ b/drivers/usb/host/Kconfig > @@ -94,6 +94,35 @@ config USB_XHCI_TEGRA > Say 'Y' to enable the support for the xHCI host controller > found in NVIDIA Tegra124 and later SoCs. > > +config USB_OHCI_BRCM > + tristate This symbol is not used any more. > + > +config USB_EHCI_BRCM > + tristate > + > +config USB_XHCI_BRCM > + tristate > + > +config BRCM_USB_PHY > + tristate > + > +config USB_BRCM > + tristate "Broadcom STB USB support" > + depends on ARCH_BRCMSTB > + select USB_OHCI_HCD_PLATFORM if USB_OHCI_HCD > + select USB_EHCI_BRCM if USB_EHCI_HCD > + select USB_XHCI_BRCM if USB_XHCI_HCD > + select USB_XHCI_PLATFORM if USB_XHCI_HCD > + select BRCM_USB_PHY if USB_OHCI_HCD || USB_EHCI_HCD || USB_XHCI_HCD > + select GENERIC_PHY if BRCM_USB_PHY > + default ARCH_BRCMSTB > + help > + Say Y to enable support for XHCI, EHCI and OHCI host controllers > + found in Broadcom STB SoC's. > + > + Disabling this will keep the controllers and corresponding > + PHYs powered down. > + > endif # USB_XHCI_HCD > > config USB_EHCI_HCD Alan Stern