From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91E1EC32789 for ; Tue, 6 Nov 2018 16:08:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 569F22081D for ; Tue, 6 Nov 2018 16:08:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 569F22081D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=rowland.harvard.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389174AbeKGBeq (ORCPT ); Tue, 6 Nov 2018 20:34:46 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:37098 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S2388346AbeKGBeq (ORCPT ); Tue, 6 Nov 2018 20:34:46 -0500 Received: (qmail 4612 invoked by uid 2102); 6 Nov 2018 11:08:52 -0500 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 6 Nov 2018 11:08:52 -0500 Date: Tue, 6 Nov 2018 11:08:52 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Al Cooper cc: linux-kernel@vger.kernel.org, Alban Bedel , Alex Elder , Andrew Morton , Arnd Bergmann , Avi Fishman , , Bjorn Andersson , Chunfeng Yun , "David S. Miller" , , Dmitry Osipenko , Greg Kroah-Hartman , "Gustavo A. R. Silva" , Hans de Goede , James Hogan , Jianguo Sun , Johan Hovold , Kees Cook , , Lu Baolu , Mark Rutland , Martin Blumenstingl , Mathias Nyman , Mathias Nyman , Mauro Carvalho Chehab , Rishabh Bhatnagar , Rob Herring , Roger Quadros Subject: Re: [PATCH V3 4/6] usb: ohci-platform: Add support for Broadcom STB SoC's In-Reply-To: <1541453493-34981-5-git-send-email-alcooperx@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Nov 2018, Al Cooper wrote: > Add support for Broadcom STB SoC's to the ohci platform driver. > > Signed-off-by: Al Cooper > --- > @@ -177,6 +189,8 @@ static int ohci_platform_probe(struct platform_device *dev) > ohci->flags |= OHCI_QUIRK_FRAME_NO; > if (pdata->num_ports) > ohci->num_ports = pdata->num_ports; > + if (pdata->suspend_without_phy_exit) > + hcd->suspend_without_phy_exit = 1; Sorry if I missed this in the earlier discussions... Is there any possibility of adding a DT binding that could express this requirement, instead of putting it in the platform data? Alan Stern