From: Alan Stern <stern@rowland.harvard.edu>
To: syzbot <syzbot+2eb9121678bdb36e6d57@syzkaller.appspotmail.com>
Cc: andreyknvl@google.com, <dvyukov@google.com>,
<gregkh@linuxfoundation.org>, <linux-kernel@vger.kernel.org>,
<linux-usb@vger.kernel.org>, <rafael@kernel.org>,
<syzkaller-bugs@googlegroups.com>
Subject: Re: general protection fault in __dev_printk
Date: Tue, 23 Apr 2019 12:46:48 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1904231240270.1461-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <000000000000dca2f3058734c255@google.com>
On Tue, 23 Apr 2019, syzbot wrote:
> Hello,
>
> syzbot has tested the proposed patch and the reproducer did not trigger
> crash:
>
> Reported-and-tested-by:
> syzbot+2eb9121678bdb36e6d57@syzkaller.appspotmail.com
>
> Tested on:
>
> commit: d34f9519 usb-fuzzer: main usb gadget fuzzer driver
> git tree: https://github.com/google/kasan/tree/usb-fuzzer
> kernel config: https://syzkaller.appspot.com/x/.config?x=c73d1bb5aeaeae20
> compiler: gcc (GCC) 9.0.0 20181231 (experimental)
> patch: https://syzkaller.appspot.com/x/patch.diff?x=15909780a00000
>
> Note: testing is done by a robot and is best-effort only.
Okay, here's the original patch again, with the error message #if-ed
out. Maybe those messages are slowing down dummy-hcd enough that the
yurex_disconnect() routine never gets a chance to run. Although to
tell the truth, I don't see how that could happen.
Alan Stern
#syz test: https://github.com/google/kasan.git usb-fuzzer
--- a/drivers/usb/misc/yurex.c
+++ b/drivers/usb/misc/yurex.c
@@ -143,8 +143,10 @@ static void yurex_interrupt(struct urb *
/* The device is terminated, clean up */
return;
default:
+#if 0
dev_err(&dev->interface->dev,
"%s - unknown status received: %d\n", __func__, status);
+#endif
goto exit;
}
@@ -314,6 +316,7 @@ static void yurex_disconnect(struct usb_
usb_deregister_dev(interface, &yurex_class);
/* prevent more I/O from starting */
+ usb_poison_urb(dev->urb);
mutex_lock(&dev->io_mutex);
dev->interface = NULL;
mutex_unlock(&dev->io_mutex);
next prev parent reply other threads:[~2019-04-23 16:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 11:26 general protection fault in __dev_printk syzbot
2019-04-18 17:07 ` syzbot
2019-04-19 20:44 ` Alan Stern
2019-04-19 21:22 ` syzbot
2019-04-22 15:39 ` Alan Stern
2019-04-22 15:55 ` syzbot
2019-04-22 16:07 ` Alan Stern
2019-04-22 16:44 ` syzbot
2019-04-22 17:53 ` Alan Stern
2019-04-23 15:05 ` Andrey Konovalov
2019-04-23 15:28 ` Alan Stern
2019-04-23 16:06 ` syzbot
2019-04-23 16:46 ` Alan Stern [this message]
2019-04-23 17:24 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1904231240270.1461-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=syzbot+2eb9121678bdb36e6d57@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).