From: Alan Stern <stern@rowland.harvard.edu>
To: Oliver Neukum <oneukum@suse.com>
Cc: syzbot <syzbot+7bbcbe9c9ff0cd49592a@syzkaller.appspotmail.com>,
<miquel@df.uba.ar>, <andreyknvl@google.com>,
<syzkaller-bugs@googlegroups.com>, <gregkh@linuxfoundation.org>,
<rio500-users@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: possible deadlock in open_rio
Date: Wed, 7 Aug 2019 10:07:16 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44L0.1908071002310.1514-100000@iolanthe.rowland.org> (raw)
In-Reply-To: <1565185044.15973.0.camel@suse.com>
On Wed, 7 Aug 2019, Oliver Neukum wrote:
> Am Dienstag, den 06.08.2019, 15:13 -0400 schrieb Alan Stern:
> > On Thu, 1 Aug 2019, syzbot wrote:
> >
> > > Hello,
> > >
> > > syzbot found the following crash on:
> > >
> > > HEAD commit: 7f7867ff usb-fuzzer: main usb gadget fuzzer driver
> > > git tree: https://github.com/google/kasan.git usb-fuzzer
> > > console output: https://syzkaller.appspot.com/x/log.txt?x=136b6aec600000
> > > kernel config: https://syzkaller.appspot.com/x/.config?x=792eb47789f57810
> > > dashboard link: https://syzkaller.appspot.com/bug?extid=7bbcbe9c9ff0cd49592a
> > > compiler: gcc (GCC) 9.0.0 20181231 (experimental)
> > >
> > > Unfortunately, I don't have any reproducer for this crash yet.
> > >
> > > IMPORTANT: if you fix the bug, please add the following tag to the commit:
> > > Reported-by: syzbot+7bbcbe9c9ff0cd49592a@syzkaller.appspotmail.com
> > >
> > > ======================================================
> > > WARNING: possible circular locking dependency detected
> > > 5.3.0-rc2+ #23 Not tainted
> > > ------------------------------------------------------
> >
> > Andrey:
> >
> > This should be completely reproducible, since it's a simple ABBA
> > locking violation. Maybe just introducing a time delay (to avoid races
> > and give the open() call time to run) between the gadget creation and
> > gadget removal would be enough to do it.
>
> Hi,
>
> technically yes. However in practical terms the straight revert I sent
> out yesterday should fix it.
I didn't see the revert, and it doesn't appear to have reached the
mailing list archive. Can you post it again?
Alan Stern
PS: syzbot reported a similar lock inversion problem (involving two
mutexes rather than just one) in drivers/usb/misc/iowarrior.c.
Probably the two drivers need similar fixes.
next prev parent reply other threads:[~2019-08-07 14:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 15:28 possible deadlock in open_rio syzbot
2019-08-02 20:51 ` Alan Stern
2019-08-06 19:13 ` Alan Stern
2019-08-07 13:37 ` Oliver Neukum
2019-08-07 14:07 ` Alan Stern [this message]
2019-08-07 13:53 ` Andrey Konovalov
2019-08-07 14:01 ` Alan Stern
2019-08-07 14:24 ` Andrey Konovalov
2019-08-07 14:34 ` Andrey Konovalov
2019-08-07 14:38 ` Andrey Konovalov
2019-08-07 14:39 ` Alan Stern
2019-08-07 15:08 ` Andrey Konovalov
[not found] <1565187142.15973.3.camel@neukum.org>
2019-08-08 14:33 ` Alan Stern
2019-08-08 14:44 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44L0.1908071002310.1514-100000@iolanthe.rowland.org \
--to=stern@rowland.harvard.edu \
--cc=andreyknvl@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=miquel@df.uba.ar \
--cc=oneukum@suse.com \
--cc=rio500-users@lists.sourceforge.net \
--cc=syzbot+7bbcbe9c9ff0cd49592a@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).